You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/02/13 22:34:04 UTC

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5986

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................

KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
---
M thirdparty/build-definitions.sh
1 file changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5986/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS1, Line 681: TOOLSET="toolset=${CC##*/}"
> I usually have my CC/CXX set to 'ccache-clang' and 'ccache-clang++' wrapper
Yes that sounds like it would break. Checking --version seems like a good approach, and I verified it seemed to work with ccache as expected. will submit a new patch in a few minutes.


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5986

to look at the new patch set (#5).

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................

KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
---
M thirdparty/build-definitions.sh
1 file changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5986/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 679:   if [[ -n "$CC" && -n "$CXX" ]]; then
> Actually it looks like this doesn't work. The comparisons work differently,
It'll have to use -a instead of &&. Like this:

  if [ -n "$CC" -a -n "$CXX" ]; then
    ...
  fi

Should be the same after that, though.


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

thanks, yeah, I took a look and figured it was unrelated, also looked at the build log to see the boost compilation appeared to be configured properly (according to the echos in the bash script). Anyway, coming from Impala-land where we're used to flaky tests I didn't even blink.

-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

don't worry about this test failure, it's something Alexey is working on deflaking in a separate patch

-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 679:   if [[ -n "$CC" && -n "$CXX" ]]; then
> Nit: would you mind using a single square bracket (i.e. '[ -n ... ]') expre
Sure


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 683:     local COMPILER=$($CC --version | awk 'NR==1 {print $1;}')
> Can't we just do $(basename $CC) here? Even if the compiler is indirected v
not necessarily. on ubuntu you can use update-alternatives to symlink "g++" to "clang++-X.Y"


Line 687:     echo "using ${COMPILER} : : $CXX ;" > $USER_JAMFILE
> So it's OK for this to be "using gcc : : /path/to/g++ ;"? That is, for the 
yeah, that's how it's supposed to work (and what get's generated in the project-config.jam, by default_


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS1, Line 681: TOOLSET="toolset=${CC##*/}"
> my only concern about this method is if someone uses something like update-
Yeah that could be weird, is that common? Seems likely to trip up other tools that expect gcc and/or clang since there are often plenty of differences. I'm open to better ways of determining the name/compiler combination?


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/4/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS4, Line 680: Extract the compiler name from the CC path, e.g. /path/to/gcc -> gcc
this is no longer true right?


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS1, Line 681: TOOLSET="toolset=${CC##*/}"
my only concern about this method is if someone uses something like update-alternatives in ubuntu where it can just change the simlinks (i.e. make gcc/g++ simlinks can actually point to clang). In any case I'm not sure that even matters so we might as well try.


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5986

to look at the new patch set (#2).

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................

KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
---
M thirdparty/build-definitions.sh
1 file changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5986/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5986

to look at the new patch set (#4).

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................

KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
---
M thirdparty/build-definitions.sh
1 file changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5986/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Reviewed-on: http://gerrit.cloudera.org:8080/5986
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 15 insertions(+), 8 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS1, Line 681: TOOLSET="toolset=${CC##*/}"
> Yeah that could be weird, is that common? Seems likely to trip up other too
I usually have my CC/CXX set to 'ccache-clang' and 'ccache-clang++' wrapper scripts. would that break here?

It looks like both gcc and clang, if you run with '--version', the first word of the first line indicates either 'gcc' or 'clang'. Maybe that woudd work?


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 679:   if [[ -n "$CC" && -n "$CXX" ]]; then
Nit: would you mind using a single square bracket (i.e. '[ -n ... ]') expression here, to maintain consistency with the rest of the function?


Line 683:     local COMPILER=$($CC --version | awk 'NR==1 {print $1;}')
Can't we just do $(basename $CC) here? Even if the compiler is indirected via ccache, isn't the indirection done via symlink and the name of the symlink is the name of the compiler?


Line 687:     echo "using ${COMPILER} : : $CXX ;" > $USER_JAMFILE
So it's OK for this to be "using gcc : : /path/to/g++ ;"? That is, for the filename to be a path to a C++ compiler, but for the "name" of the compiler to be the more common C-based name?


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5986/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 679:   if [[ -n "$CC" && -n "$CXX" ]]; then
> Sure
Actually it looks like this doesn't work. The comparisons work differently, apparently. I'll have to spend some time reading docs to understand the difference, but it looks like I'll need the double braces. In fact, I think it's considered to be good practice unless you need shell portability but this file was already defined with #!/bin/bash


-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1870: Fix Boost build to respect CC/CXX

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5986

to look at the new patch set (#3).

Change subject: KUDU-1870: Fix Boost build to respect CC/CXX
......................................................................

KUDU-1870: Fix Boost build to respect CC/CXX

Boost doesn't respect the CC/CXX environment variables, but
they may have been set in the Kudu build environment. This
fixes this issue by configuring Boost's compiler using the
CC/CXX flags if they were set.

Testing:
- Ran thirdparty build locally, including for tsan. Checked
  that gcc/clang appeared to be set appropriately.
- Ran Impala's toolchain build with this change, verifying
  the toolchain compiler in CC/CXX was used.

Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
---
M thirdparty/build-definitions.sh
1 file changed, 15 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5986/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>