You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Niall Pemberton (JIRA)" <ve...@apache.org> on 2005/10/21 05:04:51 UTC
[jira] Created: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
velstruts - problem with an example JSP/struts tags
---------------------------------------------------
Key: VELTOOLS-53
URL: http://issues.apache.org/jira/browse/VELTOOLS-53
Project: VelocityTools
Type: Bug
Components: VelocityStruts
Reporter: Niall Pemberton
Assigned to: Nathan Bubna
Priority: Minor
See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Updated: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
Posted by "Niall Pemberton (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-53?page=all ]
Niall Pemberton updated VELTOOLS-53:
------------------------------------
Attachment: VelocityToolsStrutsApp1v2.patch
Apologies - first patch I attached contained an error in the "cancel" buttons javascript - was setting the value to 'save' rather than 'list' - this patch corrects that.
> velstruts - problem with an example JSP/struts tags
> ---------------------------------------------------
>
> Key: VELTOOLS-53
> URL: http://issues.apache.org/jira/browse/VELTOOLS-53
> Project: VelocityTools
> Type: Bug
> Components: VelocityStruts
> Reporter: Niall Pemberton
> Assignee: Nathan Bubna
> Priority: Minor
> Attachments: VelocityToolsStrutsApp1.patch, VelocityToolsStrutsApp1v2.patch
>
> See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
> The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
> I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
Posted by "Niall Pemberton (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-53?page=comments#action_12332694 ]
Niall Pemberton commented on VELTOOLS-53:
-----------------------------------------
Nathan, One minor point - I notice you didn't include the <jsp:useBean> statement I put in the patch for edit-address.jsp.
The first time in to "app1" if you first select the "Velocity Version" from the examples page and then select "Edit Address (JSP)" then a ServletException (Cannot find bean address in any scope) is thrown. Having the <jsp:useBean> ensures the AddressBean is created in session scope if it doesn't exist.
Navigating via the "JSP Version" works OK, because that JSP already has a <jsp:useBean> statement.
Niall
> velstruts - problem with an example JSP/struts tags
> ---------------------------------------------------
>
> Key: VELTOOLS-53
> URL: http://issues.apache.org/jira/browse/VELTOOLS-53
> Project: VelocityTools
> Type: Bug
> Components: VelocityStruts
> Reporter: Niall Pemberton
> Assignee: Nathan Bubna
> Priority: Minor
> Fix For: 1.2
> Attachments: VelocityToolsStrutsApp1.patch, VelocityToolsStrutsApp1v2.patch
>
> See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
> The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
> I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Resolved: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-53?page=all ]
Nathan Bubna resolved VELTOOLS-53:
----------------------------------
Fix Version: 1.2
Resolution: Fixed
Thanks, Niall! Once again, you are my hero. :)
http://svn.apache.org/viewcvs?rev=327082&view=rev
> velstruts - problem with an example JSP/struts tags
> ---------------------------------------------------
>
> Key: VELTOOLS-53
> URL: http://issues.apache.org/jira/browse/VELTOOLS-53
> Project: VelocityTools
> Type: Bug
> Components: VelocityStruts
> Reporter: Niall Pemberton
> Assignee: Nathan Bubna
> Priority: Minor
> Fix For: 1.2
> Attachments: VelocityToolsStrutsApp1.patch, VelocityToolsStrutsApp1v2.patch
>
> See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
> The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
> I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Updated: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
Posted by "Niall Pemberton (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-53?page=all ]
Niall Pemberton updated VELTOOLS-53:
------------------------------------
Attachment: VelocityToolsStrutsApp1.patch
Patch correcting the issues with the JSP pages for Struts 1.2.x
> velstruts - problem with an example JSP/struts tags
> ---------------------------------------------------
>
> Key: VELTOOLS-53
> URL: http://issues.apache.org/jira/browse/VELTOOLS-53
> Project: VelocityTools
> Type: Bug
> Components: VelocityStruts
> Reporter: Niall Pemberton
> Assignee: Nathan Bubna
> Priority: Minor
> Attachments: VelocityToolsStrutsApp1.patch
>
> See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
> The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
> I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELTOOLS-53) velstruts - problem with an example JSP/struts tags
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-53?page=comments#action_12332873 ]
Nathan Bubna commented on VELTOOLS-53:
--------------------------------------
oops. missed that... i just made the changes by hand, and it worked when i tried it, so i didn't notice the oversight. thanks for catching it!
it's fixed now. rev327683
> velstruts - problem with an example JSP/struts tags
> ---------------------------------------------------
>
> Key: VELTOOLS-53
> URL: http://issues.apache.org/jira/browse/VELTOOLS-53
> Project: VelocityTools
> Type: Bug
> Components: VelocityStruts
> Reporter: Niall Pemberton
> Assignee: Nathan Bubna
> Priority: Minor
> Fix For: 1.2
> Attachments: VelocityToolsStrutsApp1.patch, VelocityToolsStrutsApp1v2.patch
>
> See: http://www.mail-archive.com/velocity-dev%40jakarta.apache.org/msg13343.html
> The Struts <html:form> tag has had a number of attributes removed in version 1.2.x. The form name, type and scope can no longer be specified on this tag - these are now looked up in the struts-config.xml.
> I'm attaching a patch which resolves the above issue. Also I noticed that the JSP example was missing the "languages" field that is on the equivalent velocity page. The patch also includes this field on the JSP pages so that the JSP/velocity pages are directly comparable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org