You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by jaiganeshm <no...@github.com> on 2014/09/24 08:34:24 UTC
[jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
You can merge this Pull Request by running:
git pull https://github.com/jaiganeshm/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/531
-- Commit Summary --
* Update the GUEST_MASK so that the global identifier is retrieved for
* Updated the requests to include globalIdentifier
-- File Changes --
M providers/softlayer/src/main/java/org/jclouds/softlayer/features/AccountApi.java (2)
M providers/softlayer/src/test/java/org/jclouds/softlayer/features/AccountApiExpectTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/531.patch
https://github.com/jclouds/jclouds/pull/531.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Andrea Turli <no...@github.com>.
Thanks @jaiganeshm I'll review that asap, so that we can merge it soon.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57944005
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1670](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1670/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56634702
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by jaiganeshm <no...@github.com>.
Pls find the stack trace in the below gist link
https://gist.github.com/jaiganeshm/1ef746374c7e53b2eaa7
Rgds
Jai
On Sat, Sep 27, 2014 at 6:47 PM, Andrew Phillips <no...@github.com>
wrote:
> When running the live tests, I am getting the NoClassDefFoundError for
> JoranException.
>
> Could you put the stacktrace in a Gist or Pastie or so and add a link to
> it?
>
> Thanks, @jaiganeshm <https://github.com/jaiganeshm>!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/531#issuecomment-57069551>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57072089
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Everett Toews <no...@github.com>.
Thanks for the pull request but it's release week in jclouds and that means it's time to clean up the PR queue. This PR will be over 6 months old as of April 1. If you intend to continue work on it, please make a comment by April 2. Otherwise it will be closed on April 3.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-85715651
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by jaiganeshm <no...@github.com>.
Hi Andrew,
I haven't tested any live tests yet. What is the right way to specify the
"property softlayer.identity" for live tests.
I have my junits that was failing for createNodeWithGroupEncodedIntoName
when there were private images in my account. After this change it is
passing.
However , I will run the live tests and get back.
Rgds
Jai
On Wed, Sep 24, 2014 at 1:28 PM, Andrew Phillips <no...@github.com>
wrote:
> jclouds-pull-requests #1196 UNSTABLE
>
> Spurious test failure
> <https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds%24jclouds-compute/1196/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/>
> - the SoftLayer tests are OK now.
>
> Thanks for the updates, @jaiganeshm <https://github.com/jaiganeshm>! Just
> want to check that you've verified that this change actually allows a live
> test that is currently failing to pass? Could you indicate which (if any)
> test that is?
>
> Code change itself is +1 - looks good to me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/531#issuecomment-56716291>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56913748
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #107](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/107/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56630389
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by jaiganeshm <no...@github.com>.
Thanks Andrea.
Rgds
Jai
On Sun, Oct 5, 2014 at 11:56 AM, Andrea Turli <no...@github.com>
wrote:
> Thanks @jaiganeshm <https://github.com/jaiganeshm> I'll review that asap,
> so that we can merge it soon.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/531#issuecomment-57944005>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57944119
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by jaiganeshm <no...@github.com>.
Fixed all the setup issues. I am able to get a clean pass for all the live
tests. Attached the live test results.
On Sun, Sep 28, 2014 at 3:34 AM, Andrea Turli <no...@github.com>
wrote:
> Hi Jai,
>
> To run live tests please have a look at
> http://wiki.apache.org/jclouds/Testing
> where for provider you need softlayer.
>
> HTH,
> Andrea
> Il 28/set/2014 04:02 "jaiganeshm" <no...@github.com> ha scritto:
>
> > Pls find the stack trace in the below gist link
> >
> > https://gist.github.com/jaiganeshm/1ef746374c7e53b2eaa7
> >
> > Rgds
> > Jai
> >
> > On Sat, Sep 27, 2014 at 6:47 PM, Andrew Phillips <
> notifications@github.com>
> >
> > wrote:
> >
> > > When running the live tests, I am getting the NoClassDefFoundError for
> > > JoranException.
> > >
> > > Could you put the stacktrace in a Gist or Pastie or so and add a link
> to
> > > it?
> > >
> > > Thanks, @jaiganeshm <https://github.com/jaiganeshm>!
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <https://github.com/jclouds/jclouds/pull/531#issuecomment-57069551>.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/jclouds/jclouds/pull/531#issuecomment-57072089>.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/531#issuecomment-57078946>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57943916
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1196 UNSTABLE
Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/1196/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) - the SoftLayer tests are OK now.
Thanks for the updates, @jaiganeshm! Just want to check that you've verified that this change actually allows a live test that is currently failing to pass? Could you indicate which (if any) test that is?
Code change itself is +1 - looks good to me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56716291
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Everett Toews <no...@github.com>.
Closed #531.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#event-272761027
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by jaiganeshm <no...@github.com>.
When running the live tests, I am getting the NoClassDefFoundError for
JoranException.
I removed the logging module from the modules and then the live test
proceeded (without and logs ofcourse). Even thought I could see node
getting created and deleted later, I was still getting the NoCLassDefFound
error for one test case. Attaching the snapshots.
Let me know if anyone knows how to get rid of the NoCLassDefFoundError.
THanks
Jai
On Thu, Sep 25, 2014 at 9:54 PM, Jai M <ja...@gmail.com> wrote:
> Hi Andrew,
>
> I haven't tested any live tests yet. What is the right way to specify
> the "property softlayer.identity" for live tests.
> I have my junits that was failing for createNodeWithGroupEncodedIntoName
> when there were private images in my account. After this change it is
> passing.
>
> However , I will run the live tests and get back.
>
> Rgds
> Jai
>
>
> On Wed, Sep 24, 2014 at 1:28 PM, Andrew Phillips <notifications@github.com
> > wrote:
>
>> jclouds-pull-requests #1196 UNSTABLE
>>
>> Spurious test failure
>> <https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds%24jclouds-compute/1196/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/>
>> - the SoftLayer tests are OK now.
>>
>> Thanks for the updates, @jaiganeshm <https://github.com/jaiganeshm>!
>> Just want to check that you've verified that this change actually allows a
>> live test that is currently failing to pass? Could you indicate which (if
>> any) test that is?
>>
>> Code change itself is +1 - looks good to me.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/jclouds/jclouds/pull/531#issuecomment-56716291>.
>>
>
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57029079
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Andrew Phillips <no...@github.com>.
> When running the live tests, I am getting the NoClassDefFoundError for
JoranException.
Could you put the stacktrace in a Gist or Pastie or so and add a link to it?
Thanks, @jaiganeshm!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57069551
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Ignasi Barrera <no...@github.com>.
Thanks @jaiganeshm! @andreaturli mind having a look at this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56792388
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1196](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1196/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-56635861
Re: [jclouds] Updated the requests in unit test case to include
globalIdentifier (#531)
Posted by Andrea Turli <no...@github.com>.
Hi Jai,
To run live tests please have a look at
http://wiki.apache.org/jclouds/Testing
where for provider you need softlayer.
HTH,
Andrea
Il 28/set/2014 04:02 "jaiganeshm" <no...@github.com> ha scritto:
> Pls find the stack trace in the below gist link
>
> https://gist.github.com/jaiganeshm/1ef746374c7e53b2eaa7
>
> Rgds
> Jai
>
> On Sat, Sep 27, 2014 at 6:47 PM, Andrew Phillips <no...@github.com>
>
> wrote:
>
> > When running the live tests, I am getting the NoClassDefFoundError for
> > JoranException.
> >
> > Could you put the stacktrace in a Gist or Pastie or so and add a link to
> > it?
> >
> > Thanks, @jaiganeshm <https://github.com/jaiganeshm>!
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/jclouds/jclouds/pull/531#issuecomment-57069551>.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/531#issuecomment-57072089>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/531#issuecomment-57078946