You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "minnguyen27 (via GitHub)" <gi...@apache.org> on 2026/10/19 04:19:46 UTC

Re: [PR] JAMES-4236 EmailSubmission/set reject an unknown identityId [james-project]

minnguyen27 commented on code in PR #3252:
URL: https://github.com/apache/james-project/pull/3252#discussion_r4310291002


##########
third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinContract.java:
##########
@@ -455,6 +455,7 @@ default void bobSendSpamEmailToAlice(UserCredential bobCredential) {
                 "            \"accountId\": \"" + bobCredential.accountId() + "\"," +
                 "            \"create\": {" +
                 "                \"k1490\": {" +
+                "                    \"identityId\": \"" + bobCredential.identityId() + "\"," +

Review Comment:
   Thank you both for noticing this. I changed it so that a missing `identityId` is accepted again, as before. An `identityId` that is unknown, invalid, or belongs to another user is still rejected with `invalidProperties`
   
   i has opened a follow-up issue https://github.com/linagora/tmail-flutter/issues/5003 for flutter FE to fix the case no custom identity exists; the composer falls back to a server-set identity (`mayDelete: false`) for sending, and sends its ID as `identityId`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org