You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2022/09/10 13:34:35 UTC

[plc4x] branch develop updated: docs(plc4j/ads): Added a comment about stuff I learned recently.

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 4663ff971 docs(plc4j/ads): Added a comment about stuff I learned recently.
4663ff971 is described below

commit 4663ff9716bc54656a1e5b5678b400009e1a5b5f
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Sat Sep 10 15:34:23 2022 +0200

    docs(plc4j/ads): Added a comment about stuff I learned recently.
---
 protocols/ads/src/main/resources/protocols/ads/ads.mspec | 1 +
 1 file changed, 1 insertion(+)

diff --git a/protocols/ads/src/main/resources/protocols/ads/ads.mspec b/protocols/ads/src/main/resources/protocols/ads/ads.mspec
index da3ce1603..8b6dc8cfb 100644
--- a/protocols/ads/src/main/resources/protocols/ads/ads.mspec
+++ b/protocols/ads/src/main/resources/protocols/ads/ads.mspec
@@ -882,6 +882,7 @@
 
 // In data-type child entries, the name seems to be used by the property name and the data-type name seems to contain
 // what in the parent case the "name" attribute seems to use.
+// TODO: In general only the propertyName, dataTypeName and offset are interesting here. The rest is mostly not fully initialized
 [discriminatedType AdsDataTypeTableChildEntry byteOrder='LITTLE_ENDIAN'
 	[simple   uint 32                          entryLength                                                            ]
 	[simple   uint 32                          version                                                                ]