You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/05 09:02:27 UTC
[GitHub] [solr] janhoy opened a new pull request, #1275: SOLR-16532 Further improvements to opentelemetry module
janhoy opened a new pull request, #1275:
URL: https://github.com/apache/solr/pull/1275
https://issues.apache.org/jira/browse/SOLR-16532
I created a new PR where we can gather all followup cleanups that may arrive after the initial merge in #1168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1275: SOLR-16532 Further improvements to opentelemetry module
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1275:
URL: https://github.com/apache/solr/pull/1275#issuecomment-1371955037
@dsmiley Regarding the hope of excluding some dependencies, we received a reply in https://github.com/open-telemetry/opentelemetry-java/discussions/5079#discussioncomment-4595701, so it seems hard to get rid of the -log and -metric deps.
This jack claims that we should be able to exclude 'okhttp' and 'kotlin', but when I tried IIRC it was a hard dependency of gRPC lib. If you want to give it a shot that would be great. It would make those test-dependencies only starting from 10.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1275: SOLR-16532 Further improvements to opentelemetry module
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1275:
URL: https://github.com/apache/solr/pull/1275#issuecomment-1381934345
Anything more we should fix in this same PR? I kind of gave up on slimming down the jars for now, but feel free to give it a shot if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1275: SOLR-16532 Further improvements to opentelemetry module
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1275:
URL: https://github.com/apache/solr/pull/1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org