You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jens-G (via GitHub)" <gi...@apache.org> on 2026/10/14 21:53:01 UTC
[PR] Remove an unreachable branch from the zlib transport's read_slow() [thrift]
Jens-G opened a new pull request, #4009:
URL: https://github.com/apache/thrift/pull/4009
`thrift_zlib_transport_read_slow()` delivers at most one byte per call. `need` starts at 1 and only ever drops to 0 when that byte has been copied, and the function then returns at once. The check that follows it, `need < 1`, is therefore never true, and the early return it guards cannot be taken. This removes the check and the comment above it. Behaviour does not change.
`make -C lib/c_glib/test check-am`: 32/32 (Ubuntu 22.04 build image).
- [ ] Apache Jira ticket: none, a trivial cleanup
- [x] Single commit
- [x] Code change, so the commit carries no CI-skip marker.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove an unreachable branch from the zlib transport's read_slow() [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #4009:
URL: https://github.com/apache/thrift/pull/4009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org