You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/02/08 05:11:00 UTC
[jira] [Commented] (ARROW-4264) [C++] Convert DCHECKs in that check
compute/* input parameters to error statuses
[ https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763315#comment-16763315 ]
Wes McKinney commented on ARROW-4264:
-------------------------------------
I don't think Status should be used for type checking
> [C++] Convert DCHECKs in that check compute/* input parameters to error statuses
> --------------------------------------------------------------------------------
>
> Key: ARROW-4264
> URL: https://issues.apache.org/jira/browse/ARROW-4264
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Micah Kornfield
> Assignee: Micah Kornfield
> Priority: Minor
>
> DCHECKs seem to be used where Status::Invalid is more appropriate (so programs don't crash). See conversation on https://github.com/apache/arrow/pull/3287/files
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)