You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Martina Koch (JIRA)" <ji...@apache.org> on 2009/05/26 08:40:45 UTC
[jira] Created: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Close SegmentUpdater when FetchedSegments is closed
---------------------------------------------------
Key: NUTCH-738
URL: https://issues.apache.org/jira/browse/NUTCH-738
Project: Nutch
Issue Type: Improvement
Components: searcher
Affects Versions: 1.1
Reporter: Martina Koch
Priority: Minor
Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
(The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Martina Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martina Koch updated NUTCH-738:
-------------------------------
Attachment: FetchedSegments.patch
Patch adds close method for SegmentUpdater.
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.1
> Reporter: Martina Koch
> Priority: Minor
> Attachments: FetchedSegments.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Kirby Bohling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kirby Bohling updated NUTCH-738:
--------------------------------
Attachment: NUTCH-738.patch
Alternative implementation, that uses Thread interruption as cancel semantics. Because I'm not sure that the project properly handles interruption everywhere, I capture the interruption request to ensure the shutdown is not lost.
If this is not patch acceptable, I believe that the original patch needs to make the boolean used become volatile to conform to the Java Memory Model.
The this.$0 in the SegmentUpdater, the segmentUpdater and the fact that segmentUpdater is a GC root (all threads are GC roots), appears to confuse the GC into not releasing this cluster of objects, thus holding this the class loader in memory.
If segmentUpdater needs to stay final, just pass the values from FetchSegments and make SegmentUpdater become a static class. I believe that will also resolve the problem, but I didn't actually try it.
Using this, and the patch from NUTCH-746, and adding "-XX:+CMSClassUnloadingEnabled" to Tomcat's 6.0.18 startup script will allow the classes to be unloaded.
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.1
> Reporter: Martina Koch
> Priority: Minor
> Attachments: FetchedSegments.patch, NUTCH-738.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783289#action_12783289 ]
Andrzej Bialecki commented on NUTCH-738:
-----------------------------------------
Fixed in rev. 885150. Thank you!
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.0.0
> Reporter: Martina Koch
> Assignee: Andrzej Bialecki
> Priority: Minor
> Fix For: 1.1
>
> Attachments: FetchedSegments.patch, NUTCH-738.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Martina Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martina Koch updated NUTCH-738:
-------------------------------
Patch Info: [Patch Available]
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.1
> Reporter: Martina Koch
> Priority: Minor
> Attachments: FetchedSegments.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki closed NUTCH-738.
-----------------------------------
Resolution: Fixed
Assignee: Andrzej Bialecki
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.0.0
> Reporter: Martina Koch
> Assignee: Andrzej Bialecki
> Priority: Minor
> Fix For: 1.1
>
> Attachments: FetchedSegments.patch, NUTCH-738.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic updated NUTCH-738:
-----------------------------------
Affects Version/s: (was: 1.1)
1.0.0
Fix Version/s: 1.1
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.0.0
> Reporter: Martina Koch
> Priority: Minor
> Fix For: 1.1
>
> Attachments: FetchedSegments.patch, NUTCH-738.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-738) Close SegmentUpdater when
FetchedSegments is closed
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783359#action_12783359 ]
Hudson commented on NUTCH-738:
------------------------------
Integrated in Nutch-trunk #996 (See [http://hudson.zones.apache.org/hudson/job/Nutch-trunk/996/])
Close SegmentUpdater when FetchedSegments is closed.
> Close SegmentUpdater when FetchedSegments is closed
> ---------------------------------------------------
>
> Key: NUTCH-738
> URL: https://issues.apache.org/jira/browse/NUTCH-738
> Project: Nutch
> Issue Type: Improvement
> Components: searcher
> Affects Versions: 1.0.0
> Reporter: Martina Koch
> Assignee: Andrzej Bialecki
> Priority: Minor
> Fix For: 1.1
>
> Attachments: FetchedSegments.patch, NUTCH-738.patch
>
>
> Currently FetchedSegments starts a SegmentUpdater, but never closes it when FetchedSegments is closed.
> (The problem was described in this mailing: http://www.mail-archive.com/nutch-user@lucene.apache.org/msg13823.html)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.