[GitHub] msokolov commented on issue #562: Don't create a LeafCollector when the Scorer for the leaf is null

[GitBox <gi...@apache.org>]

msokolov commented on issue #562: Don't create a LeafCollector when the Scorer for the leaf is null
URL: https://github.com/apache/lucene-solr/pull/562#issuecomment-461412085
 
 
   Oh good point! I hadn't realized that creating a scorer could be the more
   expensive path. Actually I mostly just saw this as a cleanup with only
   slighlt positive or negligble speed gain. Our Collectors are not that
   expensive to create, so I think this is not really needed and we should not
   do it
   
   On Tue, Feb 5, 2019 at 4:32 PM Adrien Grand <no...@github.com>
   wrote:
   
   > I had considered something like that in the past but didn't like the fact
   > that it made things slower with queries whose bulk scorer is costly to
   > create (eg. range or multi-term) and collectors that can skip entire
   > segments by raising a CollectionTerminatedException in getLeafCollector.
   > Maybe we could have a way to construct bulk scorers in two steps similarly
   > to Weight#scorerSupplier for regular scorers so that we could check
   > whether a bulk scorer might have any hits without paying the full
   > construction price. I expect this would only help if a leaf collector is
   > expensive to construct, with which collector are you seeing slowdowns
   > because Lucene is constructing leaf collectors on segments that don't have
   > matches?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/lucene-solr/pull/562#issuecomment-460812077>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AA56QaNX_JxrSCBz9NVnJXdUIqU5aUmIks5vKfiEgaJpZM4ahKzm>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org