You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shiro.apache.org by "jepsar (via GitHub)" <gi...@apache.org> on 2023/06/23 14:14:22 UTC
[GitHub] [shiro] jepsar opened a new issue, #953: Add preflight support to HttpAuthenticationFilter
jepsar opened a new issue, #953:
URL: https://github.com/apache/shiro/issues/953
It would be nice if there was native (optional) support to always grant access to preflight requests.
https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request
In our JAX RS project, we added this to our filter:
```java
@Override
protected boolean isAccessAllowed(ServletRequest request, ServletResponse response, Object mappedValue) {
if (isPreflightRequest(request)) {
return true;
}
return super.isAccessAllowed(request, response, mappedValue);
}
protected boolean isPreflightRequest(ServletRequest request) {
HttpServletRequest httpRequest = WebUtils.toHttp(request);
return httpRequest.getHeader("Origin") != null && httpRequest.getMethod().equals("OPTIONS");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #953: Add preflight support to HttpAuthenticationFilter
URL: https://github.com/apache/shiro/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "celikfatih (via GitHub)" <gi...@apache.org>.
celikfatih commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-3527121120
@lprimak If no one is interested in this, can I develop this feature myself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-3527156410
> [@lprimak](https://github.com/lprimak) If no one is interested in this, can I develop this feature myself?
@celikfatih please, you are welcome to contribute!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
[GitHub] [shiro] lprimak commented on issue #953: Add preflight support to HttpAuthenticationFilter
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-1618808990
Contributions are welcome :) Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #953: Add preflight support to HttpAuthenticationFilter
URL: https://github.com/apache/shiro/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak closed issue #953: Add preflight support to HttpAuthenticationFilter
URL: https://github.com/apache/shiro/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "jub0bs (via GitHub)" <gi...@apache.org>.
jub0bs commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-1781591294
@jepsar Be careful: not all `OPTIONS` request including an `Origin` header are preflight requests. To be sure that you're dealing with a preflight request, you should check that the request also include an `Access-Control-Request-Method`. More details in https://fetch.spec.whatwg.org/#cors-preflight-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-1745846712
@jepsar any update please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #953: Add preflight support to HttpAuthenticationFilter
URL: https://github.com/apache/shiro/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "jepsar (via GitHub)" <gi...@apache.org>.
jepsar commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-1748752808
I currently have some backlog of PrimeFaces work. Not sure when I can have a look at this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
Re: [I] Add preflight support to HttpAuthenticationFilter [shiro]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #953: Add preflight support to HttpAuthenticationFilter
URL: https://github.com/apache/shiro/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org
[GitHub] [shiro] jepsar commented on issue #953: Add preflight support to HttpAuthenticationFilter
Posted by "jepsar (via GitHub)" <gi...@apache.org>.
jepsar commented on issue #953:
URL: https://github.com/apache/shiro/issues/953#issuecomment-1618924984
Let me see what I can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org