[GitHub] [ozone] umamaheswararao commented on pull request #3529: HDDS-6812. Fix INTERNAL_ERROR message on failed write.

[GitBox <gi...@apache.org>]

umamaheswararao commented on PR #3529:
URL: https://github.com/apache/ozone/pull/3529#issuecomment-1163990217

   Thanks @aswinshakil for working on this. Changes looks good to me. I have a general question: 
   try {
         for (int i = 0; i < num; i++) {
           AllocatedBlock block = scm.getScmBlockManager()
               .allocateBlock(size, replicationConfig, owner, excludeList);
           if (block != null) {
             blocks.add(block);
           }
         }
         return blocks;
       } catch (Exception ex) {
       
       Now here it will never return null since you are throwing exception? If yes, probably you may want to file a JIRA to revisit this to remove the if block!=null check and looping?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org