You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/08/10 17:52:17 UTC
Review Request 61565: Stout: Improved the readability of some
assertions/expectations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61565/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Prefer checking whether a container is empty instead of checking its
size.
Diffs
-----
3rdparty/stout/tests/flags_tests.cpp d78ab55b983ff6918733617ae8db5be29f817c69
3rdparty/stout/tests/multimap_tests.cpp 36860e43efab04cf8a2276523e6937c1918d5a90
3rdparty/stout/tests/os/filesystem_tests.cpp 841f655a19e87657de77cb57c30b8310bb5898a4
3rdparty/stout/tests/os/process_tests.cpp 4b5c25782dd67624bf139ad826142183a6d6f1a2
3rdparty/stout/tests/os_tests.cpp e8ecece1d5361e8d0e1ad42682db51b48ab6be1f
3rdparty/stout/tests/proc_tests.cpp c6d1d442df3e38d1d89716dc036b4a57ab0941b1
3rdparty/stout/tests/strings_tests.cpp a51144df652c5d456d8dab49ca8b2cbec69ea4b6
Diff: https://reviews.apache.org/r/61565/diff/1/
Testing
-------
The stout tests still pass.
Thanks,
Gastón Kleiman