You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksei Zotov (Jira)" <ji...@apache.org> on 2022/02/09 05:05:00 UTC

[jira] [Commented] (CASSANDRA-17244) Fix org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition

    [ https://issues.apache.org/jira/browse/CASSANDRA-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489243#comment-17489243 ] 

Aleksei Zotov commented on CASSANDRA-17244:
-------------------------------------------

It failed in [928|https://ci-cassandra.apache.org/job/Cassandra-trunk/928/testReport/org.apache.cassandra.distributed.test.trackwarnings/TombstoneCountWarningTest] and [935|https://ci-cassandra.apache.org/job/Cassandra-trunk/935/testReport/org.apache.cassandra.distributed.test.trackwarnings/TombstoneCountWarningTest/failThresholdSinglePartition/] builds.
{code:java}
java.lang.NullPointerException
	at com.google.common.collect.Iterables.getOnlyElement(Iterables.java:254)
	at org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThreshold(TombstoneCountWarningTest.java:273)
	at org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition(TombstoneCountWarningTest.java:186)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {code}
Looks like sometimes warnings can be unexpectedly empty. I'm not really familiar with all these classes and test utilities, however, I have a guess that it somehow maybe related to the fact which node really acts as a coordinator for
{code:java}
QueryProcessor.execute(cql, org.apache.cassandra.db.ConsistencyLevel.ALL, QueryState.forInternalCalls()); {code}
command. With that idea in mind, I feel we may need to introduce CoordinatorWarning init/done/reset logic as it was done in [https://github.com/apache/cassandra/pull/1180/files#diff-e14e42b9f28baf531cfe0fd4d79794617959d63e26e03bed54e0e1636e55d890R200.] But this is a pure speculation because I do not really understand the whole logic :) I hope [~dcapwell] can comment on this.

If it does not seem to be the right direction I'd postpone working on this ticket because I have a bunch of other test failures on Jenkins to take a look to.

> Fix org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17244
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17244
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.x
>
>
> org.apache.cassandra.distributed.test.trackwarnings.TombstoneCountWarningTest.failThresholdSinglePartition failed [here|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1354/testReport/junit/org.apache.cassandra.distributed.test.trackwarnings/TombstoneCountWarningTest/failThresholdSinglePartition/]
> I didn't find any other occurrences but seems to me legit failure.
> CC [~dcapwell] as I think you were working on those and probably you will make better assessment than me. :) 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org