You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ChristophAl <gi...@git.apache.org> on 2015/06/26 12:20:14 UTC
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
GitHub user ChristophAl opened a pull request:
https://github.com/apache/flink/pull/869
[FLINK-2278] [ml] changed Vector fromBreeze
fromBreeze now takes the actual dimensionality instead of the non-zero elements as size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristophAl/flink sparsevector
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #869
----
commit 47ed71dad80a606129d82cc9bac997a2e44f65c2
Author: Christoph Alt <ch...@posteo.de>
Date: 2015-06-26T10:17:32Z
[FLINK-2278] [ml] changed Vector fromBreeze
fromBreeze now takes the actual dimensionality instead of the non-zero elements as size
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/869#issuecomment-115640417
Next time, you can directly assign the JIRA issue to yourself when you create it, then we know that you will be working on this issue. Can you please close this PR manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/869#issuecomment-115638055
Sorry, I saw your PR too late. I just fixed the issue in the master.
A side note: You missed the `BreezeVectorConverter` in `SparseVector`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
Posted by ChristophAl <gi...@git.apache.org>.
Github user ChristophAl commented on the pull request:
https://github.com/apache/flink/pull/869#issuecomment-115640388
No worries,
and thanks for the note, I did indeed miss that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/869#issuecomment-115636110
Nice catch and looks good to merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2278] [ml] changed Vector fromBreeze
Posted by ChristophAl <gi...@git.apache.org>.
Github user ChristophAl closed the pull request at:
https://github.com/apache/flink/pull/869
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---