You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by aroberson <gi...@git.apache.org> on 2015/04/16 04:01:00 UTC
[GitHub] cordova-plugin-file pull request: FileProxy.js makeNativeURL() wil...
GitHub user aroberson opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/112
FileProxy.js makeNativeURL() will cause invalid url if last and first characters are / in WIndows
This is a fix when accessing the nativeURL of a FileEntry on Windows. If the file is created and the root.nativeURL contains a '/' at the end, and the path contains a '/' at its beginning. The native url generated is invalid when you try to access it by calling FileEntry.toURL();
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ABB-Austin/cordova-plugin-file master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 8035313d43e0446d730592c4f1cb68b9f26a989b
Author: aroberson <ad...@ventyx.abb.com>
Date: 2015-04-16T01:49:26Z
Corrected logic to build native URL to check for forward slash on native and path variables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: FileProxy.js makeNativeURL() wil...
Posted by mariol3 <gi...@git.apache.org>.
Github user mariol3 commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/112#issuecomment-206808003
+1 for this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request #112: FileProxy.js makeNativeURL() will cau...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org