You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stricklandrbls (via GitHub)" <gi...@apache.org> on 2023/03/27 16:12:13 UTC
[GitHub] [daffodil-vscode] stricklandrbls opened a new pull request, #534: Updated byte symbol for undefinedCharStandIn
stricklandrbls opened a new pull request, #534:
URL: https://github.com/apache/daffodil-vscode/pull/534
- The current committed symbol is not a monospace symbol which was causing logical viewport display issues.
Closes #531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #534: Updated byte symbol for undefinedCharStandIn
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on a diff in pull request #534: Updated byte symbol for undefinedCharStandIn
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1151008815
##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
bytes: ArrayBuffer,
bytesPerRow: number
): string {
- const undefinedCharStandIn = '�'
+ const undefinedCharStandIn = '░'
Review Comment:
Sure thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #534: Updated byte symbol for undefinedCharStandIn
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1151003450
##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
bytes: ArrayBuffer,
bytesPerRow: number
): string {
- const undefinedCharStandIn = '�'
+ const undefinedCharStandIn = '░'
Review Comment:
@stricklandrbls Can we instead change this variable to be `const undefinedCharCodeStandIn = 9617`? Then when you go to use it do `String.fromCharCode(undefinedCharCodeStandIn)`? I was able to get this char code value by doing `console.log('░'.charCodeAt(0))` in a nodejs shell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #534: Updated byte symbol for undefinedCharStandIn
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1151003450
##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
bytes: ArrayBuffer,
bytesPerRow: number
): string {
- const undefinedCharStandIn = '�'
+ const undefinedCharStandIn = '░'
Review Comment:
@stricklandrbls Can we instead change this variable to be `const undefinedCharCodeStandIn = 9617`? Then when you go to use it do `String.fromCharCode(undefinedCharCodeStandIn)`?
I was able to get this char code value by doing `console.log('░'.charCodeAt(0))` and convert back to its string using the `String.fromCharCode` method mentioned above in a nodejs shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #534: Updated byte symbol for undefinedCharStandIn
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #534:
URL: https://github.com/apache/daffodil-vscode/pull/534#discussion_r1150994935
##########
src/omega_edit/utils.ts:
##########
@@ -94,7 +94,7 @@ export function logicalDisplay(
bytes: ArrayBuffer,
bytesPerRow: number
): string {
- const undefinedCharStandIn = '�'
+ const undefinedCharStandIn = '░'
Review Comment:
Is there a way to use an ascii code that when converted to a string it will give this value? Just thinking if we used a ascii code or something then convert it to a string if it produces the same result it would look cleaner that having this weird symbol in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org