You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2024/09/05 11:36:10 UTC
[PR] OPENNLP-1600 - Ability to disable POS mapper (opennlp)
rzo1 opened a new pull request, #649:
URL: https://github.com/apache/opennlp/pull/649
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
This PR introduces a new `POSTagFormat#CUSTOM` which will disable the automatic format mapping in `POSTaggerME`. In addition, it opens up the format mapper variable to be `protected`, so people can override as needed.
fyi @reckart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1600 - Ability to disable POS mapper (opennlp)
Posted by "jzonthemtn (via GitHub)" <gi...@apache.org>.
jzonthemtn commented on code in PR #649:
URL: https://github.com/apache/opennlp/pull/649#discussion_r1745584516
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormat.java:
##########
@@ -23,5 +23,5 @@
*/
public enum POSTagFormat {
- UD, PENN, UNKNOWN
+ UD, PENN, CUSTOM, UNKNOWN
Review Comment:
Just wanted to ask about the `CUSTOM` value and the `NoOp` class names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1600 - Ability to disable POS mapper (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #649:
URL: https://github.com/apache/opennlp/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1600 - Ability to disable POS mapper (opennlp)
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on code in PR #649:
URL: https://github.com/apache/opennlp/pull/649#discussion_r1745710893
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormat.java:
##########
@@ -23,5 +23,5 @@
*/
public enum POSTagFormat {
- UD, PENN, UNKNOWN
+ UD, PENN, CUSTOM, UNKNOWN
Review Comment:
IMHO `NO_OP` would be adequate if the enum defines the "mapping" process.
But if it defines the "format" (I'd probably rather call it "tagset" than "format" then, but ok), then `CUSTOM` may be more sensible.
In the end, as long as it means the mapper can be turned off... it is probable fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1600 - Ability to disable POS mapper (opennlp)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #649:
URL: https://github.com/apache/opennlp/pull/649#discussion_r1745596107
##########
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormat.java:
##########
@@ -23,5 +23,5 @@
*/
public enum POSTagFormat {
- UD, PENN, UNKNOWN
+ UD, PENN, CUSTOM, UNKNOWN
Review Comment:
Would you prefer a no-op value here? I was thinking as a user wanting to have custom tags :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org