[jira] [Commented] (PARQUET-1717) parquet-thrift converts Thrift i16 to parquet INT32 instead of INT_16

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993615#comment-16993615 ] 

ASF GitHub Bot commented on PARQUET-1717:
-----------------------------------------

ebrard commented on pull request #706: [PARQUET-1717] Convert i16 thrift to INT16 logical type instead
URL: https://github.com/apache/parquet-mr/pull/706
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [PARQUET-1717](https://issues.apache.org/jira/browse/PARQUET/PARQUET-1717)
   
   ### Tests
   
   - [X] My PR does not need testing for this extremely good reason: No new functions were added
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> parquet-thrift converts Thrift i16 to parquet INT32 instead of INT_16
> ---------------------------------------------------------------------
>
>                 Key: PARQUET-1717
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1717
>             Project: Parquet
>          Issue Type: Wish
>          Components: parquet-thrift
>    Affects Versions: 1.11.0
>            Reporter: Emmanuel Brard
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently when converting Thrift to Parquet, the ThriftSchemaConverter will convert a i16 thrift data type as a INT32 Parquet data type even if the logical type INT(16, false) would be more representative, especially for downstream consumers of the parquet files.
> Using the logical data type requires a change in this method:
> {code:java}
>  @Override
>   public ConvertedField visit(I16Type i16Type, State state) {
>     return visitPrimitiveType(INT32, state);
>   }
> {code}
> from the ThriftSchemaConvertVisitor



--
This message was sent by Atlassian Jira
(v8.3.4#803005)