[GitHub] [echarts] pissang commented on pull request #13902: fix(Calendar): fix day label drifting. close #11508

[GitBox <gi...@apache.org>]

pissang commented on pull request #13902:
URL: https://github.com/apache/echarts/pull/13902#issuecomment-809870121


   Sorry for the late review. Is it better to use the smaller dimension like:
   ```ts
   margin = numberUtil.parsePercent(margin, Math.min(cellSize[1], cellSize[0]);
   ```
   Since `cellSize[1]` may also be too large when calendar layout is vertical


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org