You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "Jens-G (via GitHub)" <gi...@apache.org> on 2026/09/11 12:04:43 UTC

Re: [PR] THRIFT-5806: Count zero set fields on a nil union rather than dereferencing it [thrift]

Jens-G commented on PR #3822:
URL: https://github.com/apache/thrift/pull/3822#issuecomment-5634152356

   ### Code review
   
   Found 1 issue:
   
   1. The commit has no AI attribution trailer, although the PR description says the change was created with AI assistance (AGENTS.md says "**Always** label AI-assisted commits and PRs. Use one or both of: `Co-Authored-By: <AI tool name and version>` / `Generated-by: <AI tool name and version>`"). The PR text names no tool or version either. The commits of #3816 and #3817 carry such a trailer.
   
   https://github.com/apache/thrift/blob/3eeb97b2f4f8326c7c8ee5a9d1f2c2cce3c40e41/AGENTS.md#L60-L74
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org