You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jel476 (via GitHub)" <gi...@apache.org> on 2023/02/14 15:14:08 UTC
[GitHub] [airflow] jel476 opened a new issue, #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
jel476 opened a new issue, #29538:
URL: https://github.com/apache/airflow/issues/29538
### Apache Airflow version
Other Airflow 2 version (please specify below)
### What happened
Hello,
My organization has been running Airflow 2.3.4 and we have run into a problem in regard to the Google Campaign Manager Report Sensor. The purpose of this sensor is to check if a report has finished processing and is ready to be downloaded. If we use API Version: v3.5 it works flawlessly. Unfortunately, if we use API Version v4, the sensor malfunctions. It always succeeds regardless of whether the report is ready to download or not. This causes the job to fail downstream because it makes it impossible to download a file that it is not ready.
At first this doesn't seem like a big problem in just using v3.5. However, Google announced that they are going to only let you use API version v4 starting in a week. Is there a way we can get this resolved �
Thanks!
### What you think should happen instead
_No response_
### How to reproduce
_No response_
### Operating System
linux?
### Versions of Apache Airflow Providers
_No response_
### Deployment
Composer
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1509825843
@jel476 fix is in https://github.com/apache/airflow/pull/30598 by @VladaZakharova
It will be available in the next provider release.
From what I see in the fix the issue is only with the default value of `api_version` thus nothing prevents you from using version 4 of the api with older versions of the google provider simply pass the version you use explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lwyszomi commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "lwyszomi (via GitHub)" <gi...@apache.org>.
lwyszomi commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1432611302
@eladkal we are working on some of deprecations, and this is also in our plans to fix soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1430216761
> Google support linked me to this issues forum 🥺
That is unfortunate.
This is open source project people contribute on their free will so as i said PRs are welcome.
@lwyszomi maybe you can ping someone in Google to take this task before planned deprecation? I'm willing to assist with cutting RC version for Google provider as soon as fix is merged but someone will need to take this take and implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
URL: https://github.com/apache/airflow/issues/29538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1429908485
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jel476 commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "jel476 (via GitHub)" <gi...@apache.org>.
jel476 commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1430181280
Google support linked me to this issues forum 🥺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1430222677
BTW @jel476 I should have asked first. Which sensor are you referring to? I don't see Google ads sensor in the project. can you please link to the relevant file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #29538: GoogleCampaignManagerReportSensor not working correctly on API Version V4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #29538:
URL: https://github.com/apache/airflow/issues/29538#issuecomment-1430172186
There are several google services that require attention
https://github.com/apache/airflow/issues/27292
PRs are welcome. This is one of the cases that best auited to be handled by a user of the service / someone from Google
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org