You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/14 12:55:04 UTC

[jira] [Commented] (CB-6976) Add support for Windows Universal apps (Windows 8.1 and WP 8.1)

    [ https://issues.apache.org/jira/browse/CB-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626191#comment-14626191 ] 

ASF GitHub Bot commented on CB-6976:
------------------------------------

Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/259#discussion_r34556418
  
    --- Diff: cordova-lib/src/cordova/prepare.js ---
    @@ -106,28 +106,29 @@ function prepare(options) {
                 if (options.browserify) {
                     plugman.prepare = require('../plugman/prepare-browserify');
                 }
    -            plugman.prepare(platformPath, platform, plugins_dir, null, true, pluginInfoProvider);
    -
    -            // Make sure that config changes for each existing plugin is in place
    -            var platformJson = PlatformJson.load(plugins_dir, platform);
    -            var munger = new PlatformMunger(platform, platformPath, plugins_dir, platformJson, pluginInfoProvider);
    -            munger.reapply_global_munge();
    -            munger.save_all();
    -
    -            // Update platform config.xml based on top level config.xml
    -            var cfg = new ConfigParser(xml);
    -            var platform_cfg = new ConfigParser(parser.config_xml());
    -            exports._mergeXml(cfg.doc.getroot(), platform_cfg.doc.getroot(), platform, true);
    -
    -            // CB-6976 Windows Universal Apps. For smooth transition and to prevent mass api failures
    -            // we allow using windows8 tag for new windows platform
    -            if (platform == 'windows') {
    -                exports._mergeXml(cfg.doc.getroot(), platform_cfg.doc.getroot(), 'windows8', true);
    -            }
    -
    -            platform_cfg.write();
    -
    -            return parser.update_project(cfg);
    +            var preparePromise =  plugman.prepare(platformPath, platform, plugins_dir, null, true, pluginInfoProvider);
    +            return Q(preparePromise).then(function () {                   
    --- End diff --
    
    Since plugman.prepare() returns a promise, you should just be able to do this:
    
    ```js
    return plugman.prepare(platformPath, platform, plugins_dir, null, true, pluginInfoProvider)
    .then(function () {
    ```
    



> Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
> ---------------------------------------------------------------
>
>                 Key: CB-6976
>                 URL: https://issues.apache.org/jira/browse/CB-6976
>             Project: Apache Cordova
>          Issue Type: New Feature
>            Reporter: Sergey Grebnov
>
> Creating this as a new JIRA feature since this is different from previously proposed adding support for Windows 8.1 only.
> This feature proposes transforming 'windows8' to 'windows' platform which is based on Windows Universal apps and which allows building apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. 
> Original info from dev mail thread:
> With Windows 8.1 and Windows Phone 8.1 platforms released, it would be great to get Cordova support building apps for those platforms too. A lot of people on this list have also been talking about how to adapt existing apps to the new 8.1 platforms. Here is an initial proposal and prototype of how it may look. 
> TL;DR; - Rename windows8 platform to be called windows. This platform can build apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. 
> Link to the document - https://onedrive.live.com/redir?resid=DEA20E6DC28C96DD!2781&authkey=!APz1za6lnJhsaaQ&ithint=file%2c.docx
> For more details, see "Support for Windows Universal apps (Windows 8.1 and Windows Phone 8.1)" dev email thread
> TODO: add Windows 8.1 and WP8.1 components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org