You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by el...@apache.org on 2011/08/11 23:31:00 UTC
svn commit: r1156839 - in /hadoop/common/trunk/hadoop-common: CHANGES.txt
src/test/java/org/apache/hadoop/io/compress/TestCodec.java
Author: eli
Date: Thu Aug 11 21:30:59 2011
New Revision: 1156839
URL: http://svn.apache.org/viewvc?rev=1156839&view=rev
Log:
HADOOP-7357. hadoop.io.compress.TestCodec#main() should exit with non-zero exit code if test failed. Contributed by Philip Zeyliger
Modified:
hadoop/common/trunk/hadoop-common/CHANGES.txt
hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
Modified: hadoop/common/trunk/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common/CHANGES.txt?rev=1156839&r1=1156838&r2=1156839&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-common/CHANGES.txt Thu Aug 11 21:30:59 2011
@@ -481,6 +481,9 @@ Trunk (unreleased changes)
HADOOP-7512. Fix example mistake in WritableComparable javadocs.
(Harsh J via eli)
+ HADOOP-7357. hadoop.io.compress.TestCodec#main() should exit with
+ non-zero exit code if test failed. (Philip Zeyliger via eli)
+
Release 0.22.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java?rev=1156839&r1=1156838&r2=1156839&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java (original)
+++ hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java Thu Aug 11 21:30:59 2011
@@ -501,7 +501,7 @@ public class TestCodec {
LOG.info("SUCCESS! Completed SequenceFileCodecTest with codec \"" + codecClass + "\"");
}
- public static void main(String[] args) {
+ public static void main(String[] args) throws IOException {
int count = 10000;
String codecClass = "org.apache.hadoop.io.compress.DefaultCodec";
@@ -511,25 +511,20 @@ public class TestCodec {
System.exit(-1);
}
- try {
- for (int i=0; i < args.length; ++i) { // parse command line
- if (args[i] == null) {
- continue;
- } else if (args[i].equals("-count")) {
- count = Integer.parseInt(args[++i]);
- } else if (args[i].equals("-codec")) {
- codecClass = args[++i];
- }
+ for (int i=0; i < args.length; ++i) { // parse command line
+ if (args[i] == null) {
+ continue;
+ } else if (args[i].equals("-count")) {
+ count = Integer.parseInt(args[++i]);
+ } else if (args[i].equals("-codec")) {
+ codecClass = args[++i];
}
-
- Configuration conf = new Configuration();
- int seed = 0;
- codecTest(conf, seed, count, codecClass);
- } catch (Exception e) {
- System.err.println("Caught: " + e);
- e.printStackTrace();
}
+ Configuration conf = new Configuration();
+ int seed = 0;
+ // Note that exceptions will propagate out.
+ codecTest(conf, seed, count, codecClass);
}
@Test