[GitHub] [hive] kasakrisz commented on a diff in pull request #3246: HIVE-26160: Materialized View rewrite does not check tables scanned in sub-query expressions

[GitBox <gi...@apache.org>]

kasakrisz commented on code in PR #3246:
URL: https://github.com/apache/hive/pull/3246#discussion_r859840470


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -2107,7 +2108,10 @@ private boolean isMaterializedViewRewritingByTextEnabled() {
     }
 
     private RelNode applyMaterializedViewRewritingByText(
-            ASTNode queryToRewriteAST, RelNode originalPlan, RelOptCluster optCluster) {
+            ASTNode queryToRewriteAST,
+            RelNode originalPlan,
+            RelOptCluster optCluster,
+            RelMetadataProvider metadataProvider) {

Review Comment:
   It returns a different provider.
   [removeSubqueries](https://github.com/apache/hive/blob/7583142cbffcb3958a546a9aaa15700bbc243df9/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L2395) could also get a provider from the plan in it's 1st param like
   
   ```
   basePlan.getCluster().getMetadataProvider()
   ```
   However this does not returns the same instance passed in the 2nd parameter.
   
   
   One provider instance has 14 entries the other one has 22.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org