[GitHub] [skywalking] IanCao commented on issue #2605: Support span#error in toolkit

[GitBox <gi...@apache.org>]

IanCao commented on issue #2605: Support span#error in toolkit
URL: https://github.com/apache/skywalking/pull/2605#issuecomment-489565567
 
 
   > > I suggest that to add error message or an exception in ActiveSpan#error API, Because the user will confused why this span occurs an exception when the span without any error message or an exception.
   > 
   > @ascrutae Exception is a log API, do you suggest to add that?
   
   i have added three error methods and test case
   
   ```
      public static void error() {
       }
       public static void error(String key, String errorMsg) {
       }
       public static void error(Throwable throwable) {
       }
   ```
   plz review~
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services