(opendal) branch ConcurrentLimitLayer-for-java created (now e5045ef96b)

[ti...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tison pushed a change to branch ConcurrentLimitLayer-for-java
in repository https://gitbox.apache.org/repos/asf/opendal.git


      at e5045ef96b feat(bindings/java): support ConcurrentLimitLayer

This branch includes the following new commits:

     new e5045ef96b feat(bindings/java): support ConcurrentLimitLayer

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(opendal) 01/01: feat(bindings/java): support ConcurrentLimitLayer

[ti...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tison pushed a commit to branch ConcurrentLimitLayer-for-java
in repository https://gitbox.apache.org/repos/asf/opendal.git

commit e5045ef96bde80ed63aa3c11f0fcef9356abb00b
Author: tison <wa...@gmail.com>
AuthorDate: Mon Oct 7 07:46:27 2024 -0600

    feat(bindings/java): support ConcurrentLimitLayer
    
    Signed-off-by: tison <wa...@gmail.com>
---
 bindings/java/src/layer.rs                         | 13 +++++++++
 .../apache/opendal/layer/ConcurrentLimitLayer.java | 33 ++++++++++++++++++++++
 .../java/org/apache/opendal/layer/RetryLayer.java  |  6 ++++
 .../java/org/apache/opendal/test/LayerTest.java    | 11 ++++++++
 4 files changed, 63 insertions(+)

diff --git a/bindings/java/src/layer.rs b/bindings/java/src/layer.rs
index 7e3ba35fd1..acad24f02c 100644
--- a/bindings/java/src/layer.rs
+++ b/bindings/java/src/layer.rs
@@ -22,6 +22,7 @@ use jni::sys::jboolean;
 use jni::sys::jfloat;
 use jni::sys::jlong;
 use jni::JNIEnv;
+use opendal::layers::ConcurrentLimitLayer;
 use opendal::layers::RetryLayer;
 use opendal::Operator;
 
@@ -49,3 +50,15 @@ pub extern "system" fn Java_org_apache_opendal_layer_RetryLayer_doLayer(
     }
     Box::into_raw(Box::new(op.clone().layer(retry))) as jlong
 }
+
+#[no_mangle]
+pub extern "system" fn Java_org_apache_opendal_layer_ConcurrentLimitLayer_doLayer(
+    _: JNIEnv,
+    _: JClass,
+    op: *mut Operator,
+    permits: jlong,
+) -> jlong {
+    let op = unsafe { &*op };
+    let concurrent_limit = ConcurrentLimitLayer::new(permits as usize);
+    Box::into_raw(Box::new(op.clone().layer(concurrent_limit))) as jlong
+}
diff --git a/bindings/java/src/main/java/org/apache/opendal/layer/ConcurrentLimitLayer.java b/bindings/java/src/main/java/org/apache/opendal/layer/ConcurrentLimitLayer.java
new file mode 100644
index 0000000000..7d3e7a4e1a
--- /dev/null
+++ b/bindings/java/src/main/java/org/apache/opendal/layer/ConcurrentLimitLayer.java
@@ -0,0 +1,33 @@
+package org.apache.opendal.layer;
+
+import org.apache.opendal.Layer;
+
+/**
+ * Users can control how many concurrent connections could be established between
+ * OpenDAL and underlying storage services.
+ *
+ * @see <a href="https://docs.rs/opendal/latest/opendal/layers/struct.ConcurrentLimitLayer.html">ConcurrentLimitLayer's rustdoc</a>
+ */
+public class ConcurrentLimitLayer extends Layer {
+    private final long permits;
+
+    /**
+     * Create a new ConcurrentLimitLayer will specify permits.
+     *
+     * @param permits concurrent connections could be established
+     */
+    public ConcurrentLimitLayer(long permits) {
+        if (permits <= 0) {
+            throw new IllegalArgumentException("permits must be positive");
+        }
+
+        this.permits = permits;
+    }
+
+    @Override
+    protected long layer(long nativeOp) {
+        return doLayer(nativeOp, permits);
+    }
+
+    private static native long doLayer(long nativeHandle, long permits);
+}
diff --git a/bindings/java/src/main/java/org/apache/opendal/layer/RetryLayer.java b/bindings/java/src/main/java/org/apache/opendal/layer/RetryLayer.java
index 86c3bc66ee..100a84fb6d 100644
--- a/bindings/java/src/main/java/org/apache/opendal/layer/RetryLayer.java
+++ b/bindings/java/src/main/java/org/apache/opendal/layer/RetryLayer.java
@@ -23,6 +23,12 @@ import java.time.Duration;
 import lombok.Builder;
 import org.apache.opendal.Layer;
 
+/**
+ * This layer will retry failed operations when {@code Error::is_temporary} returns {@code true}.
+ * If operation still failed, this layer will set error to Persistent which means error has been retried.
+ *
+ * @see <a href="https://docs.rs/opendal/latest/opendal/layers/struct.RetryLayer.html">RetryLayer's rustdoc</a>
+ */
 @Builder
 public class RetryLayer extends Layer {
 
diff --git a/bindings/java/src/test/java/org/apache/opendal/test/LayerTest.java b/bindings/java/src/test/java/org/apache/opendal/test/LayerTest.java
index 0300bb1419..ed2ab4a1d2 100644
--- a/bindings/java/src/test/java/org/apache/opendal/test/LayerTest.java
+++ b/bindings/java/src/test/java/org/apache/opendal/test/LayerTest.java
@@ -25,6 +25,7 @@ import java.util.Map;
 import lombok.Cleanup;
 import org.apache.opendal.AsyncOperator;
 import org.apache.opendal.Layer;
+import org.apache.opendal.layer.ConcurrentLimitLayer;
 import org.apache.opendal.layer.RetryLayer;
 import org.junit.jupiter.api.Test;
 
@@ -38,4 +39,14 @@ public class LayerTest {
         @Cleanup final AsyncOperator layeredOp = op.layer(retryLayer);
         assertThat(layeredOp.info).isNotNull();
     }
+
+    @Test
+    void testOperatorWithConcurrentLimitLayer() {
+        final Map<String, String> conf = new HashMap<>();
+        conf.put("root", "/opendal/");
+        final Layer concurrentLimitLayer = new ConcurrentLimitLayer(1024);
+        @Cleanup final AsyncOperator op = AsyncOperator.of("memory", conf);
+        @Cleanup final AsyncOperator layeredOp = op.layer(concurrentLimitLayer);
+        assertThat(layeredOp.info).isNotNull();
+    }
 }