You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/10/11 19:57:16 UTC
[PR] fix: keep comments on non-ctas sql [superset]
justinpark opened a new pull request, #25617:
URL: https://github.com/apache/superset/pull/25617
### SUMMARY
Following by #12188
The current behavior always strips comments from the original SQL, which I believe helps to distinguish the last SELECT statement without comments.
At Airbnb, we wants to execute the original SQL without stripping comments in order to process an additional behavior using a custom comment block.
In order to satisfy both cases, this commit enables comment stripping only for CTAS statements.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
Run `SELECT 1 --comment` and check the executed sql
added unit tests.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: keep comments on single statement sql [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark closed pull request #25617: fix: keep comments on single statement sql
URL: https://github.com/apache/superset/pull/25617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org