[jira] [Commented] (PROTON-301) Add a valgrind-based test to the SSL unit tests.

["Ken Giusti (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642906#comment-13642906 ] 

Ken Giusti commented on PROTON-301:
-----------------------------------

I'm giving up on this.  While I still think having the SSL implementation get additional verification by running under Valgrind, it's proven to be impractical by the sheer number of valgrind errors generated by the OpenSSL libraries themselves.

A bit of googling backs this up: OpenSSL is not valgrind clean, by intent.  And since there doesn't appear to be a way to write a suppression that will ignore a particular library, the sheer volume of work needed to create suppression entries for each release of OpenSSL is just too impractical.

I've checked in the work necessary to enable valgrind tests for SSL, and I've expanded the test coverage a bit (now including Messenger-based SSL testing), but for now I'll mark this bug 'won't fix'.  Perhaps future versions of OpenSSL (or Valgrind) may make this worthwhile, but for now it isn't.


                
> Add a valgrind-based test to the SSL unit tests.
> ------------------------------------------------
>
>                 Key: PROTON-301
>                 URL: https://issues.apache.org/jira/browse/PROTON-301
>             Project: Qpid Proton
>          Issue Type: Test
>          Components: proton-c
>    Affects Versions: 0.5
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>
> The C-based SSL implementation should be run under valgrind as part of the unit tests.   All current valgrind tests use non-SSL connections.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira