You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Vanko (Code Review)" <ge...@cloudera.org> on 2026/07/29 15:36:20 UTC

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Daniel Vanko has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24643


Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................

IMPALA-12675: Add simdutf 9.0.0

Adds simdutf 9.0.0 to the toolchain, following the same pattern as
existing CMake-based packages. It is built as a static library with
tests, tools, benchmarks, and iconv support disabled.

Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Assisted-by: Claude Opus 4.8 (Claude Code)
---
M buildall.sh
A source/simdutf/build.sh
2 files changed, 56 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/43/24643/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 1:

(1 comment)

Looks good
I'd still like to ask for a shared lib variant as well; otherwise looks OK.

http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh
File source/simdutf/build.sh:

http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh@41
PS1, Line 41: DBUILD_SHARED_LIBS=OFF
We haven't yet given up on dynamically-linked Impala builds completely, so could you add building a shared lib for this? Several Google utilities (gflags, gtest) have examples.
Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jul 2026 18:11:53 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jul 2026 16:01:49 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 2: Verified+1

>Successfully build locally and on Jenkins.

Giving +1 and merging based on this.


-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Aug 2026 04:57:33 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jul 2026 18:05:33 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Csaba Ringhofer, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24643

to look at the new patch set (#2).

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................

IMPALA-12675: Add simdutf 9.0.0

Adds simdutf 9.0.0 to the toolchain, following the same pattern as
existing CMake-based packages. Both shared and static library variants
are built (like gtest, simdutf's CMake produces one or the other, so
each is built separately), with tests, tools, benchmarks, and iconv
support disabled.

Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Assisted-by: Claude Opus 4.8 (Claude Code)
---
M buildall.sh
A source/simdutf/build.sh
2 files changed, 66 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/43/24643/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................

IMPALA-12675: Add simdutf 9.0.0

Adds simdutf 9.0.0 to the toolchain, following the same pattern as
existing CMake-based packages. Both shared and static library variants
are built (like gtest, simdutf's CMake produces one or the other, so
each is built separately), with tests, tools, benchmarks, and iconv
support disabled.

Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Assisted-by: Claude Opus 4.8 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/24643
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M buildall.sh
A source/simdutf/build.sh
2 files changed, 66 insertions(+), 0 deletions(-)

Approvals:
  Laszlo Gaal: Looks good to me, but someone else must approve
  Csaba Ringhofer: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Aug 2026 04:29:32 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-12675: Add simdutf 9.0.0

Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )

Change subject: IMPALA-12675: Add simdutf 9.0.0
......................................................................


Patch Set 2:

(1 comment)

Thank you, added shared variant as well.
Successfully build locally and on Jenkins.

http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh
File source/simdutf/build.sh:

http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh@41
PS1, Line 41: 
> We haven't yet given up on dynamically-linked Impala builds completely, so 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558
Gerrit-Change-Number: 24643
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jul 2026 11:50:15 +0000
Gerrit-HasComments: Yes