[GitHub] timifasubaa opened a new pull request #5023: [sqllab] force limit queries only when there is no existing limit

[GitBox <gi...@apache.org>]

timifasubaa opened a new pull request #5023: [sqllab] force limit queries only when there is no existing limit
URL: https://github.com/apache/incubator-superset/pull/5023
 
 
   This PR (https://github.com/apache/incubator-superset/pull/4947) nicely implemented a more efficient way to limit queries by attaching the limit statement from the statement. However, it always attaches the default limit to all queries even when a smaller query is specified in the query. This is because query.limit, is always set to the default value, never the specified limit value. 
   In this PR, I do some query parsing to make sure query.limit is correctly specified upstream. Then the query augnmenting logic is only called when there no limit specified. 
   
   @mistercrunch @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org