You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Stefan Seifert <ss...@pro-vision.de> on 2016/02/04 08:28:46 UTC
RE: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
-1 for the API bundle (unless this is by intention:)
why have we in the new API bundle two different packages with path-related utility classes?
org.apache.sling.api.resource.util (SLING-5220, comparing paths)
Path
PathSet
org.apache.sling.resource.path (SLING-5455, bulding paths)
PathBuilder
the latter is even missing the "api" part in the package name - is this by intention?
perhaps Path and PathBuilder could even be combined in one single class.
stefan
>-----Original Message-----
>From: Robert Munteanu [mailto:rombert@apache.org]
>Sent: Tuesday, February 02, 2016 10:34 PM
>To: Sling Dev
>Subject: [VOTE] Release Apache Sling API 2.10.0, Apache Sling Resource
>Resolver 1.3.0, Apache Sling JCR Resource Resolver 2.6.0, Apache Sling
>Servlet Resolver 2.3.10
>
>Hi,
>
>We solved a large number of issues issues in these releases:
>
>https://issues.apache.org/jira/browse/SLING/fixforversion/12329540 (
>Apache Sling API 2.10.0, 21 issues)
>https://issues.apache.org/jira/browse/SLING/fixforversion/12332988 (
>Apache Sling Resource Resolver 1.3.0, 22 issues )
>https://issues.apache.org/jira/browse/SLING/fixforversion/12333342 (
>Apache Sling JCR Resource Resolver 2.6.0, 12 issues )
>https://issues.apache.org/jira/browse/SLING/fixforversion/12333753 (
>Apache Sling Servlet Resolver 2.3.10, 3 issues)
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1416/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1416 /tmp/sling-staging
>
>Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Carsten Ziegeler <cz...@apache.org>.
Robert Munteanu wrote
>
> Agreed, I will move the classes to a new package.
>
> Filed https://issues.apache.org/jira/browse/SLING-5486 and will commit
> the changes tomorrow.
>
Thanks Robert,
I will also rename one class in the API then, I misspelled
ResolveContext as ResolverContext.
Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2016-02-04 at 16:40 +0100, Carsten Ziegeler wrote:
> Stefan Seifert wrote
> >
> > > The PathBuilder is aimed to be more lightweight than a Path when
> > > just
> > > need to craft a String path to pass to the ResourceResolver or a
> > > similar API.
> > >
> > > It's outside the api.resource.util package since it's a
> > > standalone
> > > utility that might move outside the API bundle in the future, if
> > > we get
> > > more path-related utilities in.
> > >
> > > That being said, I see three options:
> > >
> > > 1. Go ahead with the release, given the above arguments
> > > 2. Move Path and PathSet to the resource.path package, for
> > > consistency
> > > 3. Move pack PathBuilder to the resourceresolver package as an
> > > internal
> > > class
> >
> > thanks for the explanation - so this was by intention.
> >
> > i withdraw my -1 vote on this vote.
> >
> > i personally would like 2., but with "api" in the package name. we
> > already have some utility classes in the API, why not some more
> > handling paths. esp. i would like to put all path-related classes
> > in the same package to make it easier to find them.
> >
> > but if no one else has a problem with the current package layout
> > i'm fine with it as well
>
> TBH I didn't catch that one :(, I would prefer #2 as well
>
> I guess the best would be to redo the release and fix the api
> package.
> Once we have it out, we have to support it "forever"
Agreed, I will move the classes to a new package.
Filed https://issues.apache.org/jira/browse/SLING-5486 and will commit
the changes tomorrow.
Robert
Re: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Carsten Ziegeler <cz...@apache.org>.
Stefan Seifert wrote
>
>> The PathBuilder is aimed to be more lightweight than a Path when just
>> need to craft a String path to pass to the ResourceResolver or a
>> similar API.
>>
>> It's outside the api.resource.util package since it's a standalone
>> utility that might move outside the API bundle in the future, if we get
>> more path-related utilities in.
>>
>> That being said, I see three options:
>>
>> 1. Go ahead with the release, given the above arguments
>> 2. Move Path and PathSet to the resource.path package, for consistency
>> 3. Move pack PathBuilder to the resourceresolver package as an internal
>> class
>
> thanks for the explanation - so this was by intention.
>
> i withdraw my -1 vote on this vote.
>
> i personally would like 2., but with "api" in the package name. we already have some utility classes in the API, why not some more handling paths. esp. i would like to put all path-related classes in the same package to make it easier to find them.
>
> but if no one else has a problem with the current package layout i'm fine with it as well
TBH I didn't catch that one :(, I would prefer #2 as well
I guess the best would be to redo the release and fix the api package.
Once we have it out, we have to support it "forever"
WDYT?
Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
RE: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Thursday 04 February 2016 11:59:58 Stefan Seifert wrote:
> >The PathBuilder is aimed to be more lightweight than a Path when just
> >need to craft a String path to pass to the ResourceResolver or a
> >similar API.
> >
> >It's outside the api.resource.util package since it's a standalone
> >utility that might move outside the API bundle in the future, if we get
> >more path-related utilities in.
> >
> >That being said, I see three options:
> >
> >1. Go ahead with the release, given the above arguments
> >2. Move Path and PathSet to the resource.path package, for consistency
> >3. Move pack PathBuilder to the resourceresolver package as an internal
> >class
>
>
> thanks for the explanation - so this was by intention.
>
> i withdraw my -1 vote on this vote.
>
> i personally would like 2., but with "api" in the package name. we already
> have some utility classes in the API, why not some more handling paths.
> esp. i would like to put all path-related classes in the same package to
> make it easier to find them.
+1
O.
> but if no one else has a problem with the current package layout i'm fine
> with it as well
> stefan
RE: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Stefan Seifert <ss...@pro-vision.de>.
>The PathBuilder is aimed to be more lightweight than a Path when just
>need to craft a String path to pass to the ResourceResolver or a
>similar API.
>
>It's outside the api.resource.util package since it's a standalone
>utility that might move outside the API bundle in the future, if we get
>more path-related utilities in.
>
>That being said, I see three options:
>
>1. Go ahead with the release, given the above arguments
>2. Move Path and PathSet to the resource.path package, for consistency
>3. Move pack PathBuilder to the resourceresolver package as an internal
>class
thanks for the explanation - so this was by intention.
i withdraw my -1 vote on this vote.
i personally would like 2., but with "api" in the package name. we already have some utility classes in the API, why not some more handling paths. esp. i would like to put all path-related classes in the same package to make it easier to find them.
but if no one else has a problem with the current package layout i'm fine with it as well
stefan
Re: [VOTE] Release Apache Sling API 2.10.0 ... Path util classes
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2016-02-04 at 07:28 +0000, Stefan Seifert wrote:
> -1 for the API bundle (unless this is by intention:)
>
> why have we in the new API bundle two different packages with path-
> related utility classes?
>
> org.apache.sling.api.resource.util (SLING-5220, comparing paths)
> Path
> PathSet
>
> org.apache.sling.resource.path (SLING-5455, bulding paths)
> PathBuilder
>
> the latter is even missing the "api" part in the package name - is
> this by intention?
> perhaps Path and PathBuilder could even be combined in one single
> class.
That's a good point. I initially added the PathBuilder after I got
tired of too many String-based operations ( which are easy to get wrong
when working with paths ).
The PathBuilder is aimed to be more lightweight than a Path when just
need to craft a String path to pass to the ResourceResolver or a
similar API.
It's outside the api.resource.util package since it's a standalone
utility that might move outside the API bundle in the future, if we get
more path-related utilities in.
That being said, I see three options:
1. Go ahead with the release, given the above arguments
2. Move Path and PathSet to the resource.path package, for consistency
3. Move pack PathBuilder to the resourceresolver package as an internal
class
Thoughts?
Robert
>
> stefan
>
>
> > -----Original Message-----
> > From: Robert Munteanu [mailto:rombert@apache.org]
> > Sent: Tuesday, February 02, 2016 10:34 PM
> > To: Sling Dev
> > Subject: [VOTE] Release Apache Sling API 2.10.0, Apache Sling
> > Resource
> > Resolver 1.3.0, Apache Sling JCR Resource Resolver 2.6.0, Apache
> > Sling
> > Servlet Resolver 2.3.10
> >
> > Hi,
> >
> > We solved a large number of issues issues in these releases:
> >
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12329540
> > (
> > Apache Sling API 2.10.0, 21 issues)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12332988
> > (
> > Apache Sling Resource Resolver 1.3.0, 22 issues )
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12333342
> > (
> > Apache Sling JCR Resource Resolver 2.6.0, 12 issues )
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12333753
> > (
> > Apache Sling Servlet Resolver 2.3.10, 3 issues)
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-1
> > 416/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 1416 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] 0 Don't care
> > [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.