You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/10 08:03:45 UTC

[GitHub] [rocketmq] Erik1288 opened a new issue #3741: [UNIT-TEST] Use wait-until-xxx-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Erik1288 opened a new issue #3741:
URL: https://github.com/apache/rocketmq/issues/3741


   The issue tracker is **ONLY** used for bug report(feature request need to follow [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)). Keep in mind, please check whether there is an existing same report before your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We welcome any friendly suggestions, bug fixes, collaboration and other improvements.
   
   Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   After we call an asynchronous method, subsequent tests require that the asynchronous operation has finished, usually using Thread.sleep() directly. In order to make sure that the asynchronous operation is complete, the sleep time has to be set very big. There is no need to wait so long. Therefore, wait-until-XXX-reaches is a good method to avoid busyness.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   Abstract wait-until-${async-complete}-reaches pattern for different tests.
   
   2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
   
   It will be a long-term process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3741: [UNIT-TEST] Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3741:
URL: https://github.com/apache/rocketmq/issues/3741#issuecomment-1008862588


   Good catch！Could you submit a pull request to fix the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Erik1288 commented on issue #3741: [UNIT-TEST] Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Posted by GitBox <gi...@apache.org>.
Erik1288 commented on issue #3741:
URL: https://github.com/apache/rocketmq/issues/3741#issuecomment-1008963771


   > Good catch！Could you submit a pull request to fix the issue?
   I'm working on it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3741: [UNIT-TEST] Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3741:
URL: https://github.com/apache/rocketmq/issues/3741#issuecomment-1033304899


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3741: [UNIT-TEST] Use wait-until-${async-complete}-reaches DSL instead of sleep(n) to to reduce invalid wait time.

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3741:
URL: https://github.com/apache/rocketmq/issues/3741


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org