You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/10/29 02:25:47 UTC

[GitHub] [drill] cgivre opened a new pull request #2109: DRILL-7799: REST Queries Fail if Caching is Enabled

cgivre opened a new pull request #2109:
URL: https://github.com/apache/drill/pull/2109


   # [DRILL-7799](https://issues.apache.org/jira/browse/DRILL-7799): REST Queries Fail if Caching is Enabled
   
   ## Description
   This PR fixes a minor bug in the HTTP REST storage plugin where the plugin would attempt to create the cache directory twice, causing queries to fail. This was easily fixed by disabling the cache, but now the caching works properly. 
   
   Additionally this PR addresses [DRILL-7800](https://issues.apache.org/jira/browse/DRILL-7800) which adds a limit pushdown to the storage plugin. 
   
   
   ## Documentation
   No user visible changes.
   
   ## Testing
   Tested caching manually.  Added unit test for limit pushdown.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [drill] cgivre merged pull request #2109: DRILL-7799: REST Queries Fail if Caching is Enabled

Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2109:
URL: https://github.com/apache/drill/pull/2109


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [drill] cgivre commented on pull request #2109: DRILL-7799: REST Queries Fail if Caching is Enabled

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2109:
URL: https://github.com/apache/drill/pull/2109#issuecomment-718708798


   @dzamo 
   Good catch.  Addressed review comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [drill] cgivre commented on pull request #2109: DRILL-7799: REST Queries Fail if Caching is Enabled

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2109:
URL: https://github.com/apache/drill/pull/2109#issuecomment-718733673


   @dzamo 
   Thanks for the quick review!  Commits squashed and I'll merge at the end of the day.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org