You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by "DevinLeamy (via GitHub)" <gi...@apache.org> on 2024/03/15 21:26:20 UTC
[PR] Address clang-tidy errors. [mesos]
DevinLeamy opened a new pull request, #518:
URL: https://github.com/apache/mesos/pull/518
Fixes clang-tidy errors in ebpf and cgroups2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Address clang-tidy errors. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler merged PR #518:
URL: https://github.com/apache/mesos/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Address clang-tidy errors. [mesos]
Posted by "bmahler (via GitHub)" <gi...@apache.org>.
bmahler commented on code in PR #518:
URL: https://github.com/apache/mesos/pull/518#discussion_r1526872029
##########
src/linux/ebpf.cpp:
##########
@@ -91,7 +91,10 @@ Try<int> load(const Program& program)
CHECK_ERROR(fd);
CHECK_EQ(EACCES, fd.error().code)
<< "Expected BPF syscall to fail again with EACCES";
- return Error(string("BPF verifier failed: ") + verifier_logs.c_str());
Review Comment:
can you keep the comment but use .data() instead? that seems a bit more appropriate here and I suspect won't produce the warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Address clang-tidy errors. [mesos]
Posted by "DevinLeamy (via GitHub)" <gi...@apache.org>.
DevinLeamy commented on code in PR #518:
URL: https://github.com/apache/mesos/pull/518#discussion_r1526878009
##########
src/linux/ebpf.cpp:
##########
@@ -91,7 +91,10 @@ Try<int> load(const Program& program)
CHECK_ERROR(fd);
CHECK_EQ(EACCES, fd.error().code)
<< "Expected BPF syscall to fail again with EACCES";
- return Error(string("BPF verifier failed: ") + verifier_logs.c_str());
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org