You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2016/05/11 09:14:37 UTC
Review Request 47223: RANGER-967 : Allow additional characters in
username
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47223/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-967
https://issues.apache.org/jira/browse/RANGER-967
Repository: ranger
Description
-------
**Problem Statement :**
Currently the Username field on the Create User form in the UI performs validation that restricts the value to:
[a-z0-9][a-z0-9,._-'+/@]+
I'd like to be able to add a DN as a username such as:
CN=localhost, OU=My Org, O=Apache, L=Santa Monica, ST=CA, C=US
This would require adding "=" and spaces as valid characters.
**Proposed Solution :**
Allowing "=" and spaces in username nad groupname.
Diffs
-----
security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js f54246f
security-admin/src/main/webapp/scripts/utils/XAUtils.js 71b01a3
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 45d4d15
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ac354fd
security-admin/src/main/webapp/scripts/views/users/UserForm.js 8a8c78b
Diff: https://reviews.apache.org/r/47223/diff/
Testing
-------
**Verified:**
CRUD operations for users and login scenario's
Verified all combinations of allowed characters for users.
CRUD operations for Policies
Verified allocation of permissions to the newly created user using Permission Model.
Thanks,
Gautam Borad
Re: Review Request 47223: RANGER-967 : Allow additional characters in
username
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47223/#review133366
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 11, 2016, 9:14 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47223/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 9:14 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-967
> https://issues.apache.org/jira/browse/RANGER-967
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement :**
> Currently the Username field on the Create User form in the UI performs validation that restricts the value to:
> [a-z0-9][a-z0-9,._-'+/@]+
> I'd like to be able to add a DN as a username such as:
> CN=localhost, OU=My Org, O=Apache, L=Santa Monica, ST=CA, C=US
> This would require adding "=" and spaces as valid characters.
>
> **Proposed Solution :**
> Allowing "=" and spaces in username nad groupname.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js f54246f
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 71b01a3
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 45d4d15
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ac354fd
> security-admin/src/main/webapp/scripts/views/users/UserForm.js 8a8c78b
>
> Diff: https://reviews.apache.org/r/47223/diff/
>
>
> Testing
> -------
>
> **Verified:**
> CRUD operations for users and login scenario's
> Verified all combinations of allowed characters for users.
> CRUD operations for Policies
> Verified allocation of permissions to the newly created user using Permission Model.
>
>
> Thanks,
>
> Gautam Borad
>
>