You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/12/11 20:02:18 UTC

[jira] Created: (HBASE-2040) Fixes to group commit

Fixes to group commit
---------------------

                 Key: HBASE-2040
                 URL: https://issues.apache.org/jira/browse/HBASE-2040
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: Jean-Daniel Cryans
            Assignee: Jean-Daniel Cryans
             Fix For: 0.21.0
         Attachments: HBASE-2040.patch

Two (somewhat) major things.

First when the LogSyncer thread is created it's expecting optionalFlushInterval but we pass logflushentries. What it means is that it will run every 100ms by default.

Also when the optional flush is running (meaning that no entries came in for that interval) and that logflushentries>1 then it won't do the hflush because we don't enforce it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-2040) Fixes to group commit

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-2040:
--------------------------------------

    Attachment: HBASE-2040.patch

This patch addresses both issues.

> Fixes to group commit
> ---------------------
>
>                 Key: HBASE-2040
>                 URL: https://issues.apache.org/jira/browse/HBASE-2040
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2040.patch
>
>
> Two (somewhat) major things.
> First when the LogSyncer thread is created it's expecting optionalFlushInterval but we pass logflushentries. What it means is that it will run every 100ms by default.
> Also when the optional flush is running (meaning that no entries came in for that interval) and that logflushentries>1 then it won't do the hflush because we don't enforce it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HBASE-2040) Fixes to group commit

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-2040.
---------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

Thanks for the review Stack, committed to trunk.

> Fixes to group commit
> ---------------------
>
>                 Key: HBASE-2040
>                 URL: https://issues.apache.org/jira/browse/HBASE-2040
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2040.patch
>
>
> Two (somewhat) major things.
> First when the LogSyncer thread is created it's expecting optionalFlushInterval but we pass logflushentries. What it means is that it will run every 100ms by default.
> Also when the optional flush is running (meaning that no entries came in for that interval) and that logflushentries>1 then it won't do the hflush because we don't enforce it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-2040) Fixes to group commit

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789462#action_12789462 ] 

stack commented on HBASE-2040:
------------------------------

+1


> Fixes to group commit
> ---------------------
>
>                 Key: HBASE-2040
>                 URL: https://issues.apache.org/jira/browse/HBASE-2040
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2040.patch
>
>
> Two (somewhat) major things.
> First when the LogSyncer thread is created it's expecting optionalFlushInterval but we pass logflushentries. What it means is that it will run every 100ms by default.
> Also when the optional flush is running (meaning that no entries came in for that interval) and that logflushentries>1 then it won't do the hflush because we don't enforce it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.