You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2015/10/02 05:56:02 UTC

[GitHub] cordova-docs pull request: Docs Versioning

GitHub user dblotsky opened a pull request:

    https://github.com/apache/cordova-docs/pull/367

    Docs Versioning

    - Fixed formatting in English docs README and added instructions for version-bumping docs
    - Rewrote `incrementversion.js` script and added `version` and `newversion` Gulp tasks
    - Made `latest_docs_version` dynamic using the `_version.yml` file (generated from `VERSION` file)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-docs cordova-website-increment-version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #367
    
----
commit 772f3d90e7cab3b417c9350420bf9de286440830
Author: Dmitry Blotsky <dm...@gmail.com>
Date:   2015-10-02T03:50:04Z

    Fixing formatting in docs README. Adding instructions and script for version-bumping docs. Made latest_docs_version come from the VERSION file, through the _version.yml file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Docs Versioning

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/367#discussion_r41071271
  
    --- Diff: doc/README/en/README.md ---
    @@ -145,88 +143,83 @@ Crowdin, the markdown files could contain unnescessary lines, which lead to brok
     not needed code sections for example.
     
     ### Validate JSDoc tool.
    -The tool `validatejsdoc` allow verification of the current implementation of JSDoc with reference implementation.
    -It was used during porting JSDoc to the Node version of JSDoc, and now currently not used in the workflow.
    +
    +The tool `validatejsdoc` allow verification of the current implementation of JSDoc with reference implementation. It was used during porting JSDoc to the Node version of JSDoc, and now currently not used in the workflow.
     
     Recommendations for the translators
    --------------------------
    -If you intend to create quality translation of the Cordova docs, please not only
    -work in Crowdin and translate documentation, but also please go extra mile and verify that
    -generated documentation for your language is also produce quality results.
    +-----------------------------------
    +
    +If you intend to create quality translation of the Cordova docs, please not only work in Crowdin and translate documentation, but also please go extra mile and verify that generated documentation for your language is also produce quality results.
    --- End diff --
    
    Will fix them all in one go at a later point, since there are *many* more in this file and others.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Docs Versioning

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-docs/pull/367


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: Docs Versioning

Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/367#discussion_r41037563
  
    --- Diff: doc/README/en/README.md ---
    @@ -145,88 +143,83 @@ Crowdin, the markdown files could contain unnescessary lines, which lead to brok
     not needed code sections for example.
     
     ### Validate JSDoc tool.
    -The tool `validatejsdoc` allow verification of the current implementation of JSDoc with reference implementation.
    -It was used during porting JSDoc to the Node version of JSDoc, and now currently not used in the workflow.
    +
    +The tool `validatejsdoc` allow verification of the current implementation of JSDoc with reference implementation. It was used during porting JSDoc to the Node version of JSDoc, and now currently not used in the workflow.
     
     Recommendations for the translators
    --------------------------
    -If you intend to create quality translation of the Cordova docs, please not only
    -work in Crowdin and translate documentation, but also please go extra mile and verify that
    -generated documentation for your language is also produce quality results.
    +-----------------------------------
    +
    +If you intend to create quality translation of the Cordova docs, please not only work in Crowdin and translate documentation, but also please go extra mile and verify that generated documentation for your language is also produce quality results.
    --- End diff --
    
    Grammar Fixes:
    If you intend to create a quality translation of the Cordova docs, please don't only translate the documentation in Crowdin, but also go the extra mile and verify that the generated documentation for your language is producing quality results.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org