You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Stanislav Kozlovski <st...@confluent.io> on 2018/11/06 09:00:06 UTC
[VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Hey everybody,
I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics'
default values
<https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345>
In short, after the discussion thread
<https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E>,
we decided to have all min/avg/max metrics output `NaN` as a default value.
--
Best,
Stanislav
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default
values
Posted by Harsha Chintalapani <ka...@harsha.io>.
+1 (binding)
-Harsha
On Nov 6, 2018, 8:04 AM -0800, Kevin Lu <lu...@berkeley.edu>, wrote:
> +1 (non-binding)
>
> Regards,
> Kevin
>
> On Tue, Nov 6, 2018 at 1:01 AM Stanislav Kozlovski <st...@confluent.io>
> wrote:
>
> > Hey everybody,
> >
> > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics'
> > default values
> > <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
> > >
> > In short, after the discussion thread
> > <
> > https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E
> > > ,
> > we decided to have all min/avg/max metrics output `NaN` as a default value.
> >
> > --
> > Best,
> > Stanislav
> >
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Posted by Kevin Lu <lu...@berkeley.edu>.
+1 (non-binding)
Regards,
Kevin
On Tue, Nov 6, 2018 at 1:01 AM Stanislav Kozlovski <st...@confluent.io>
wrote:
> Hey everybody,
>
> I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics'
> default values
> <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
> >
> In short, after the discussion thread
> <
> https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E
> >,
> we decided to have all min/avg/max metrics output `NaN` as a default value.
>
> --
> Best,
> Stanislav
>
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Posted by Stanislav Kozlovski <st...@confluent.io>.
Hey everybody,
I've finished with the implementation, here is the PR:
https://github.com/apache/kafka/pull/5908
On Mon, Nov 12, 2018 at 6:58 PM Stanislav Kozlovski <st...@confluent.io>
wrote:
> Thank you, everybody, for the votes and discussion. The KIP has passed
> with 3 binding votes (Harsha, Jun, Dong) and 1 non-binding vote (Kevin)
>
> @jun, I added a note on the KIP stating that this isn't related to the
> Yammer metrics
>
> Best,
> Stanislav
>
> On Thu, Nov 8, 2018 at 10:54 PM Dong Lin <li...@gmail.com> wrote:
>
>> Thanks for the KIP Stanislav. +1 (binding)
>>
>> On Thu, Nov 8, 2018 at 2:40 PM Jun Rao <ju...@confluent.io> wrote:
>>
>> > Hi, Stanislav,
>> >
>> > Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not
>> the
>> > Yammer metrics). It would be useful to make this clear.
>> >
>> > Jun
>> >
>> > On Tue, Nov 6, 2018 at 1:00 AM, Stanislav Kozlovski <
>> > stanislav@confluent.io>
>> > wrote:
>> >
>> > > Hey everybody,
>> > >
>> > > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max
>> > metrics'
>> > > default values
>> > > <
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
>> > > >
>> > > In short, after the discussion thread
>> > > <https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f
>> > > 4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E>,
>> > > we decided to have all min/avg/max metrics output `NaN` as a default
>> > value.
>> > >
>> > > --
>> > > Best,
>> > > Stanislav
>> > >
>> >
>>
>
>
> --
> Best,
> Stanislav
>
--
Best,
Stanislav
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Posted by Stanislav Kozlovski <st...@confluent.io>.
Thank you, everybody, for the votes and discussion. The KIP has passed with
3 binding votes (Harsha, Jun, Dong) and 1 non-binding vote (Kevin)
@jun, I added a note on the KIP stating that this isn't related to the
Yammer metrics
Best,
Stanislav
On Thu, Nov 8, 2018 at 10:54 PM Dong Lin <li...@gmail.com> wrote:
> Thanks for the KIP Stanislav. +1 (binding)
>
> On Thu, Nov 8, 2018 at 2:40 PM Jun Rao <ju...@confluent.io> wrote:
>
> > Hi, Stanislav,
> >
> > Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not
> the
> > Yammer metrics). It would be useful to make this clear.
> >
> > Jun
> >
> > On Tue, Nov 6, 2018 at 1:00 AM, Stanislav Kozlovski <
> > stanislav@confluent.io>
> > wrote:
> >
> > > Hey everybody,
> > >
> > > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max
> > metrics'
> > > default values
> > > <
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
> > > >
> > > In short, after the discussion thread
> > > <https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f
> > > 4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E>,
> > > we decided to have all min/avg/max metrics output `NaN` as a default
> > value.
> > >
> > > --
> > > Best,
> > > Stanislav
> > >
> >
>
--
Best,
Stanislav
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Posted by Dong Lin <li...@gmail.com>.
Thanks for the KIP Stanislav. +1 (binding)
On Thu, Nov 8, 2018 at 2:40 PM Jun Rao <ju...@confluent.io> wrote:
> Hi, Stanislav,
>
> Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not the
> Yammer metrics). It would be useful to make this clear.
>
> Jun
>
> On Tue, Nov 6, 2018 at 1:00 AM, Stanislav Kozlovski <
> stanislav@confluent.io>
> wrote:
>
> > Hey everybody,
> >
> > I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max
> metrics'
> > default values
> > <
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
> > >
> > In short, after the discussion thread
> > <https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f
> > 4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E>,
> > we decided to have all min/avg/max metrics output `NaN` as a default
> value.
> >
> > --
> > Best,
> > Stanislav
> >
>
Re: [VOTE] KIP-386: Standardize on Min/Avg/Max metrics' default values
Posted by Jun Rao <ju...@confluent.io>.
Hi, Stanislav,
Thanks for the KIP. +1. I guess this only covers the Kafka metrics (not the
Yammer metrics). It would be useful to make this clear.
Jun
On Tue, Nov 6, 2018 at 1:00 AM, Stanislav Kozlovski <st...@confluent.io>
wrote:
> Hey everybody,
>
> I'm starting a vote thread on KIP-386: Standardize on Min/Avg/Max metrics'
> default values
> <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95652345
> >
> In short, after the discussion thread
> <https://lists.apache.org/thread.html/78b501fb296b05ee7da601dba1558f
> 4b9014fbb50f663bf14e5aec67@%3Cdev.kafka.apache.org%3E>,
> we decided to have all min/avg/max metrics output `NaN` as a default value.
>
> --
> Best,
> Stanislav
>