You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/03/31 07:11:33 UTC

spark git commit: [SPARK-5124][Core] Move StopCoordinator to the receive method since it does not require a reply

Repository: spark
Updated Branches:
  refs/heads/master b8ff2bc61 -> 56775571c


[SPARK-5124][Core] Move StopCoordinator to the receive method since it does not require a reply

Hotfix for #4588

cc rxin

Author: zsxwing <zs...@gmail.com>

Closes #5283 from zsxwing/hotfix and squashes the following commits:

cf3e5a7 [zsxwing] Move StopCoordinator to the receive method since it does not require a reply


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/56775571
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/56775571
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/56775571

Branch: refs/heads/master
Commit: 56775571cb938c819e5f7c3d49c5dd416ed034cb
Parents: b8ff2bc
Author: zsxwing <zs...@gmail.com>
Authored: Mon Mar 30 22:10:49 2015 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Mon Mar 30 22:10:49 2015 -0700

----------------------------------------------------------------------
 .../apache/spark/scheduler/OutputCommitCoordinator.scala  | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/56775571/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala b/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
index f748f39..17055e2 100644
--- a/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
+++ b/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala
@@ -156,14 +156,16 @@ private[spark] object OutputCommitCoordinator {
       override val rpcEnv: RpcEnv, outputCommitCoordinator: OutputCommitCoordinator)
     extends RpcEndpoint with Logging {
 
+    override def receive: PartialFunction[Any, Unit] = {
+      case StopCoordinator =>
+        logInfo("OutputCommitCoordinator stopped!")
+        stop()
+    }
+
     override def receiveAndReply(context: RpcCallContext): PartialFunction[Any, Unit] = {
       case AskPermissionToCommitOutput(stage, partition, taskAttempt) =>
         context.reply(
           outputCommitCoordinator.handleAskPermissionToCommit(stage, partition, taskAttempt))
-      case StopCoordinator =>
-        logInfo("OutputCommitCoordinator stopped!")
-        context.reply(true)
-        stop()
     }
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org