[GitHub] flink pull request #4158: [FLINK-7052][blob] remove (unused) NAME_ADDRESSABL...

[zentol <gi...@git.apache.org>]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4158#discussion_r126381889
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -551,33 +425,17 @@ else if (response == RETURN_ERROR) {
     	 * @param jobID
     	 *        the ID of job the BLOB belongs to or <code>null</code> to indicate the upload of a
     	 *        content-addressable BLOB
    -	 * @param key
    -	 *        the key of the BLOB to upload or <code>null</code> to indicate the upload of a content-addressable BLOB
     	 * @throws IOException
     	 *         thrown if an I/O error occurs while writing the header data to the output stream
     	 */
    -	private void sendPutHeader(OutputStream outputStream, JobID jobID, String key) throws IOException {
    -		// sanity check that either both are null or both are not null
    -		if ((jobID != null || key != null) && !(jobID != null && key != null)) {
    -			throw new IllegalArgumentException();
    -		}
    +	private void sendPutHeader(OutputStream outputStream, JobID jobID) throws IOException {
    +		checkArgument(jobID == null);
    --- End diff --
    
    should this be `!=`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---