You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "sgup432 (via GitHub)" <gi...@apache.org> on 2026/07/16 01:33:46 UTC
[PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
sgup432 opened a new pull request, #16399:
URL: https://github.com/apache/lucene/pull/16399
### Description
While going through the doc values code where we check the value range for multi valued use-case(and cardinality is not fixed), I see we end up calling 2 decode calls for each doc like below:
```
long startOffset = addresses.get(currentDoc); // decode from disk
long endOffset = addresses.get(currentDoc + 1L);
```
Seems redundant for consecutive documents. We can avoid one unnecessary `addresses.get()` call by storing the previous offset. This is what this PR does. Simple change.
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "sgup432 (via GitHub)" <gi...@apache.org>.
sgup432 commented on PR #16399:
URL: https://github.com/apache/lucene/pull/16399#issuecomment-5349650698
@romseygeek You may want to check this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "sgup432 (via GitHub)" <gi...@apache.org>.
sgup432 commented on PR #16399:
URL: https://github.com/apache/lucene/pull/16399#issuecomment-5197776775
@romseygeek You might want to take another look at this. Added a CHANGES entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16399:
URL: https://github.com/apache/lucene/pull/16399#issuecomment-5349604877
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #16399:
URL: https://github.com/apache/lucene/pull/16399#issuecomment-5355639612
I saw this while going through my email backlog; LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #16399:
URL: https://github.com/apache/lucene/pull/16399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet [lucene]
Posted by "sgup432 (via GitHub)" <gi...@apache.org>.
sgup432 commented on PR #16399:
URL: https://github.com/apache/lucene/pull/16399#issuecomment-5006563144
@costin @romseygeek Do you folks mind taking a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org