You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/08/11 01:41:48 UTC
Review Request 37326: Added a TODO on recordio::Decoder for EOF
semantics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37326/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
I ommitted EOF semantics since we didn't strictly need it yet, this adds a TODO to let those reading the code know that this is missing.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp e3dc00a668941dc352a1ffa346ce076036e5ec07
Diff: https://reviews.apache.org/r/37326/diff/
Testing
-------
N/A
Thanks,
Ben Mahler
Re: Review Request 37326: Added a TODO on recordio::Decoder for EOF
semantics.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37326/#review94834
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 10, 2015, 11:41 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37326/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 11:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I ommitted EOF semantics since we didn't strictly need it yet, this adds a TODO to let those reading the code know that this is missing.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp e3dc00a668941dc352a1ffa346ce076036e5ec07
>
> Diff: https://reviews.apache.org/r/37326/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Ben Mahler
>
>