[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5480: net/can/can_setsockopt.c: fix assertion, value can be NULL

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5480:
URL: https://github.com/apache/incubator-nuttx/pull/5480#discussion_r805319740



##########
File path: net/can/can_setsockopt.c
##########
@@ -76,7 +76,7 @@ int can_setsockopt(FAR struct socket *psock, int option,
   int ret = OK;
   int count = 0;
 
-  DEBUGASSERT(psock != NULL && value != NULL && psock->s_conn != NULL);
+  DEBUGASSERT(psock != NULL && psock->s_conn != NULL);

Review comment:
       why not change to:
   DEBUGASSERT(psock != NULL && psock->s_conn != NULL);
   DEBUGASSERT(value_len == 0 || value != NULL);
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org