You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/14 17:18:07 UTC
Review Request 33172: UPGRADE: Due to changes in Ambari API some
response validations should be allowed with warning message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33172/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: branch-2.0.maint
https://issues.apache.org/jira/browse/branch-2.0.maint
Repository: ambari
Description
-------
upgradeHelper use well old realization of curl via shell execute. And to handle response errors use some kind of validation of response. For new releases of Ambari response content could be changed from time to time. We need to add some "soft" validation without generation error and just warn user about unexpected response.
Diffs
-----
ambari-server/src/main/python/upgradeHelper.py 11292e9
ambari-server/src/test/python/TestUpgradeHelper.py 2f47620
Diff: https://reviews.apache.org/r/33172/diff/
Testing
-------
----------------------------------------------------------------------
Ran 262 tests in 6.250s
OK
----------------------------------------------------------------------
Total run:641
Total errors:0
Total failures:0
OK
Thanks,
Dmitro Lisnichenko
Re: Review Request 33172: UPGRADE: Due to changes in Ambari API some
response validations should be allowed with warning message
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33172/#review80028
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Квітень 14, 2015, 3:18 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33172/
> -----------------------------------------------------------
>
> (Updated Квітень 14, 2015, 3:18 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: branch-2.0.maint
> https://issues.apache.org/jira/browse/branch-2.0.maint
>
>
> Repository: ambari
>
>
> Description
> -------
>
> upgradeHelper use well old realization of curl via shell execute. And to handle response errors use some kind of validation of response. For new releases of Ambari response content could be changed from time to time. We need to add some "soft" validation without generation error and just warn user about unexpected response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/upgradeHelper.py 11292e9
> ambari-server/src/test/python/TestUpgradeHelper.py 2f47620
>
> Diff: https://reviews.apache.org/r/33172/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 262 tests in 6.250s
>
> OK
> ----------------------------------------------------------------------
> Total run:641
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>