[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

[GitBox <gi...@apache.org>]

bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r891178198


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##########
@@ -216,11 +224,16 @@ private void saslNegotiate(final Channel ch) {
       failInit(ch, e);
       return;
     }
-    ch.pipeline().addFirst(new SaslChallengeDecoder(), saslHandler);
+    if (conf.getBoolean(HBASE_NETTY_RPCSERVER_TLS_ENABLED, false)) {

Review Comment:
   Does it make sense to have a separate config for client vs server? I also wonder if we should remove `netty` from the config name, since we may expand this to blocking on the client side as well. I will probably look at doing that once this lands.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org