You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/01/22 17:54:36 UTC

svn commit: r1437046 - in /commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers: dump/DumpArchiveInputStreamTest.java tar/TarArchiveInputStreamTest.java zip/ZipArchiveInputStreamTest.java

Author: sebb
Date: Tue Jan 22 16:54:36 2013
New Revision: 1437046

URL: http://svn.apache.org/viewvc?rev=1437046&view=rev
Log:
Oops, closed the stream too early

Modified:
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStreamTest.java

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java?rev=1437046&r1=1437045&r2=1437046&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStreamTest.java Tue Jan 22 16:54:36 2013
@@ -61,13 +61,13 @@ public class DumpArchiveInputStreamTest 
         while (dump.getNextDumpEntry() != null) {
             // just consume the archive
         }
-        dump.close();
         byte[] expected = new byte[] {
             'H', 'e', 'l', 'l', 'o', ',', ' ', 'w', 'o', 'r', 'l', 'd', '!', '\n'
         };
         byte[] actual = new byte[expected.length];
         is.read(actual);
         assertArrayEquals(expected, actual);
+        dump.close();
     }
 
 }

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java?rev=1437046&r1=1437045&r2=1437046&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java Tue Jan 22 16:54:36 2013
@@ -174,13 +174,13 @@ public class TarArchiveInputStreamTest {
         while (tar.getNextTarEntry() != null) {
             // just consume the archive
         }
-        tar.close();
         byte[] expected = new byte[] {
             'H', 'e', 'l', 'l', 'o', ',', ' ', 'w', 'o', 'r', 'l', 'd', '!', '\n'
         };
         byte[] actual = new byte[expected.length];
         is.read(actual);
         assertArrayEquals(expected, actual);
+        tar.close();
     }
 
     private TarArchiveInputStream getTestStream(String name) {

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStreamTest.java?rev=1437046&r1=1437045&r2=1437046&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStreamTest.java Tue Jan 22 16:54:36 2013
@@ -89,12 +89,12 @@ public class ZipArchiveInputStreamTest {
         while (zip.getNextZipEntry() != null) {
             // just consume the archive
         }
-        zip.close();
         byte[] expected = new byte[] {
             'H', 'e', 'l', 'l', 'o', ',', ' ', 'w', 'o', 'r', 'l', 'd', '!', '\n'
         };
         byte[] actual = new byte[expected.length];
         is.read(actual);
         assertArrayEquals(expected, actual);
+        zip.close();
     }
 }