You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/01 02:53:20 UTC

[GitHub] [hbase] Reidddddd commented on a change in pull request #1821: HBASE-24480: Deflake TestRSGroupsBasics#testClearDeadServers

Reidddddd commented on a change in pull request #1821:
URL: https://github.com/apache/hbase/pull/1821#discussion_r433021673



##########
File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##########
@@ -385,7 +386,7 @@ public RSGroupInfoManager getRSGroupInfoManager() throws IOException {
   }
 
   @Override
-  public void removeServers(Set<Address> servers) throws IOException {
+  public void removeServers(@Nullable Set<Address> servers) throws IOException {

Review comment:
       I don't mean annotation `Nullable` is not good, but HBase doesn't use it around the codebases. So here makes me feel not unified, what about comment the nullable at the method @ parma description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org