[jira] [Work logged] (BEAM-5327) Go support for custom dataflow worker jar

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5327?focusedWorklogId=152956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152956 ]

ASF GitHub Bot logged work on BEAM-5327:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/18 22:54
            Start Date: 09/Oct/18 22:54
    Worklog Time Spent: 10m 
      Work Description: HuangLED commented on a change in pull request #6336: [BEAM-5327] Add support for custom dataflow worker jar in Go
URL: https://github.com/apache/beam/pull/6336#discussion_r223889977
 
 

 ##########
 File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
 ##########
 @@ -82,6 +84,21 @@ func Translate(p *pb.Pipeline, opts *JobOptions, workerURL, modelURL string) (*d
 		return nil, fmt.Errorf("Dataflow supports one container image only: %v", images)
 	}
 
+	packages := []*df.Package{{
+		Name:     "worker",
+		Location: workerURL,
+	}}
+	experiments := append(opts.Experiments, "beam_fn_api")
 
 Review comment:
   When the job is created, it seems we just passes a path pointing to the jar (rather than the actual jar file) to dataflow service side, right? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 152956)
    Time Spent: 50m  (was: 40m)

> Go support for custom dataflow worker jar
> -----------------------------------------
>
>                 Key: BEAM-5327
>                 URL: https://issues.apache.org/jira/browse/BEAM-5327
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>             Fix For: 2.8.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)