You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/21 07:25:15 UTC

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17429: [feat][cpp] Consumer support batch receive messages.

BewareMyPower commented on code in PR #17429:
URL: https://github.com/apache/pulsar/pull/17429#discussion_r976137440


##########
pulsar-client-cpp/.gitignore:
##########
@@ -77,6 +77,7 @@ Makefile
 cmake_install.cmake
 CMakeFiles
 CMakeCache.txt
+build/

Review Comment:
   Do not commit unrelated ignore path here. A CMake build directory can be any name, for example, I prefer `_builds` directory in my own. Adding such directories to `.gitignore` is bad.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org